<html><body><p> <pre> Hi, Mac: On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote: > Add tee client application, HDCP 1.x and 2.x authentication for > DisplayPort > to support the HDCP feature. > > Signed-off-by: mac.shen <mac.shen@mediatek.com> > --- [snip] > + > +void mdrv_dp_tx_hdcp1x_set_start_auth(struct mtk_hdcp_info > *hdcp_info, bool enable) The prefix 'mdrv' of each function seems redundant. So drop the prifix 'mdrv'. Regards, CK > +{ > +hdcp_info->hdcp1x_info.enable = enable; > + > +if (enable) { > +hdcp_info->auth_status = AUTH_INIT; > +hdcp_info->hdcp1x_info.main_states = > HDCP1X_main_state_A0; > +hdcp_info->hdcp1x_info.sub_states = > HDCP1X_sub_FSM_IDLE; > +} else { > +hdcp_info->auth_status = AUTH_ZERO; > +hdcp_info->hdcp1x_info.main_states = > HDCP1X_main_state_H2; > +hdcp_info->hdcp1x_info.sub_states = > HDCP1X_sub_FSM_IDLE; > +tee_hdcp_enable_encrypt(hdcp_info, false, HDCP_NONE); > +mhal_dp_tx_hdcp1x_start_cipher(hdcp_info, false); > +tee_hdcp1x_soft_rst(hdcp_info); > +} > + > +hdcp_info->hdcp1x_info.retry_count = 0; > +} > + </pre> </p></body></html><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>