<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="#0563C1" vlink="#954F72" style="word-wrap:break-word;text-justify-trim:punctuation"> <div class="WordSection1"> <o:p> </o:p> <o:p> </o:p> > -----Original Message----- > From: Maxime Ripard <mripard@kernel.org> > Sent: 2024年1月31日 21:24 > To: Keith Zhao <keith.zhao@starfivetech.com> > Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org; > linux-kernel@vger.kernel.org; linux-riscv@lists.infradead.org; > tzimmermann@suse.de; airlied@gmail.com; krzysztof.kozlowski+dt@linaro.org; > William Qiu <william.qiu@starfivetech.com>; Xingyu Wu > <xingyu.wu@starfivetech.com>; paul.walmsley@sifive.com; > aou@eecs.berkeley.edu; palmer@dabbelt.com; p.zabel@pengutronix.de; > Shengyang Chen <shengyang.chen@starfivetech.com>; Jack Zhu > <jack.zhu@starfivetech.com>; Changhuang Liang > <changhuang.liang@starfivetech.com>; maarten.lankhorst@linux.intel.com > Subject: Re: [v3 4/6] drm/vs: Add KMS crtc&plane > > On Wed, Jan 31, 2024 at 09:33:06AM +0000, Keith Zhao wrote: > > > > > > > -----邮件原件----- > > > 发件人: Maxime Ripard <<a href="mailto:mripard@kernel.org">mripard@kernel.org</a>> > > > 发送时间: 2023年12月6日 16:56 > > > 收件人: Keith Zhao <<a href="mailto:keith.zhao@starfivetech.com">keith.zhao@starfivetech.com</a>> > > > 抄送: <a href="mailto:devicetree@vger.kernel.org">devicetree@vger.kernel.org</a>; <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a>; > > > <a href="mailto:linux-kernel@vger.kernel.org"> linux-kernel@vger.kernel.org</a>; <a href="mailto:linux-riscv@lists.infradead.org">linux-riscv@lists.infradead.org</a>; > > > <a href="mailto:tzimmermann@suse.de"> tzimmermann@suse.de</a>; <a href="mailto:airlied@gmail.com">airlied@gmail.com</a>; > > > <a href="mailto:krzysztof.kozlowski+dt@linaro.org"> krzysztof.kozlowski+dt@linaro.org</a>; > > > William Qiu <<a href="mailto:william.qiu@starfivetech.com">william.qiu@starfivetech.com</a>>; Xingyu Wu > > > <<a href="mailto:xingyu.wu@starfivetech.com">xingyu.wu@starfivetech.com</a>>; <a href="mailto:paul.walmsley@sifive.com">paul.walmsley@sifive.com</a>; > > > <a href="mailto:aou@eecs.berkeley.edu"> aou@eecs.berkeley.edu</a>; <a href="mailto:palmer@dabbelt.com">palmer@dabbelt.com</a>; <a href="mailto:p.zabel@pengutronix.de">p.zabel@pengutronix.de</a>; > > > Shengyang Chen <<a href="mailto:shengyang.chen@starfivetech.com">shengyang.chen@starfivetech.com</a>>; Jack Zhu > > > <<a href="mailto:jack.zhu@starfivetech.com">jack.zhu@starfivetech.com</a>>; Changhuang Liang > > > <<a href="mailto:changhuang.liang@starfivetech.com">changhuang.liang@starfivetech.com</a>>; > > > <a href="mailto:maarten.lankhorst@linux.intel.com"> maarten.lankhorst@linux.intel.com</a>; > > > <a href="mailto:suijingfeng@loongson.cn"> suijingfeng@loongson.cn</a> > > > 主题: Re: [v3 4/6] drm/vs: Add KMS crtc&plane > > > > > > On Mon, Dec 04, 2023 at 08:33:13PM +0800, Keith Zhao wrote: > > > > +static const struct vs_plane_info dc_hw_planes_rev0[PLANE_NUM] = { > > > > + { > > > > + .name = "Primary", > > > > + .id = PRIMARY_PLANE_0, > > > > + .type = DRM_PLANE_TYPE_PRIMARY, > > > > + .num_formats = ARRAY_SIZE(primary_overlay_format0), > > > > + .formats = primary_overlay_format0, > > > > + .num_modifiers = ARRAY_SIZE(format_modifier0), > > > > + .modifiers = format_modifier0, > > > > + .min_width = 0, > > > > + .min_height = 0, > > > > + .max_width = 4096, > > > > + .max_height = 4096, > > > > + .rotation = DRM_MODE_ROTATE_0 | > > > > + DRM_MODE_ROTATE_90 | > > > > + DRM_MODE_ROTATE_180 | > > > > + DRM_MODE_ROTATE_270 | > > > > + DRM_MODE_REFLECT_X | > > > > + DRM_MODE_REFLECT_Y, > > > > + .blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) | > > > > + BIT(DRM_MODE_BLEND_PREMULTI) | > > > > + BIT(DRM_MODE_BLEND_COVERAGE), > > > > + .color_encoding = BIT(DRM_COLOR_YCBCR_BT709) | > > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > > + .degamma_size = DEGAMMA_SIZE, > > > > + .min_scale = FRAC_16_16(1, 3), > > > > + .max_scale = FRAC_16_16(10, 1), > > > > + .zpos = 0, > > > > + .watermark = true, > > > > + .color_mgmt = true, > > > > + .roi = true, > > > > + }, > > > > + { > > > > + .name = "Overlay", > > > > + .id = OVERLAY_PLANE_0, > > > > + .type = DRM_PLANE_TYPE_OVERLAY, > > > > + .num_formats = ARRAY_SIZE(primary_overlay_format0), > > > > + .formats = primary_overlay_format0, > > > > + .num_modifiers = ARRAY_SIZE(format_modifier0), > > > > + .modifiers = format_modifier0, > > > > + .min_width = 0, > > > > + .min_height = 0, > > > > + .max_width = 4096, > > > > + .max_height = 4096, > > > > + .rotation = DRM_MODE_ROTATE_0 | > > > > + DRM_MODE_ROTATE_90 | > > > > + DRM_MODE_ROTATE_180 | > > > > + DRM_MODE_ROTATE_270 | > > > > + DRM_MODE_REFLECT_X | > > > > + DRM_MODE_REFLECT_Y, > > > > + .blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) | > > > > + BIT(DRM_MODE_BLEND_PREMULTI) | > > > > + BIT(DRM_MODE_BLEND_COVERAGE), > > > > + .color_encoding = BIT(DRM_COLOR_YCBCR_BT709) | > > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > > + .degamma_size = DEGAMMA_SIZE, > > > > + .min_scale = FRAC_16_16(1, 3), > > > > + .max_scale = FRAC_16_16(10, 1), > > > > + .zpos = 1, > > > > + .watermark = true, > > > > + .color_mgmt = true, > > > > + .roi = true, > > > > + }, > > > > + { > > > > + .name = "Overlay_1", > > > > + .id = OVERLAY_PLANE_1, > > > > + .type = DRM_PLANE_TYPE_OVERLAY, > > > > + .num_formats = ARRAY_SIZE(primary_overlay_format0), > > > > + .formats = primary_overlay_format0, > > > > + .num_modifiers = > ARRAY_SIZE(secondary_format_modifiers), > > > > + .modifiers = secondary_format_modifiers, > > > > + .min_width = 0, > > > > + .min_height = 0, > > > > + .max_width = 4096, > > > > + .max_height = 4096, > > > > + .rotation = 0, > > > > + .blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) | > > > > + BIT(DRM_MODE_BLEND_PREMULTI) | > > > > + BIT(DRM_MODE_BLEND_COVERAGE), > > > > + .color_encoding = BIT(DRM_COLOR_YCBCR_BT709) | > > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > > + .degamma_size = DEGAMMA_SIZE, > > > > + .min_scale = DRM_PLANE_NO_SCALING, > > > > + .max_scale = DRM_PLANE_NO_SCALING, > > > > + .zpos = 2, > > > > + .watermark = true, > > > > + .color_mgmt = true, > > > > + .roi = true, > > > > + }, > > > > + { > > > > + .name = "Primary_1", > > > > + .id = PRIMARY_PLANE_1, > > > > + .type = DRM_PLANE_TYPE_PRIMARY, > > > > + .num_formats = ARRAY_SIZE(primary_overlay_format0), > > > > + .formats = primary_overlay_format0, > > > > + .num_modifiers = ARRAY_SIZE(format_modifier0), > > > > + .modifiers = format_modifier0, > > > > + .min_width = 0, > > > > + .min_height = 0, > > > > + .max_width = 4096, > > > > + .max_height = 4096, > > > > + .rotation = DRM_MODE_ROTATE_0 | > > > > + DRM_MODE_ROTATE_90 | > > > > + DRM_MODE_ROTATE_180 | > > > > + DRM_MODE_ROTATE_270 | > > > > + DRM_MODE_REFLECT_X | > > > > + DRM_MODE_REFLECT_Y, > > > > + .blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) | > > > > + BIT(DRM_MODE_BLEND_PREMULTI) | > > > > + BIT(DRM_MODE_BLEND_COVERAGE), > > > > + .color_encoding = BIT(DRM_COLOR_YCBCR_BT709) | > > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > > + .degamma_size = DEGAMMA_SIZE, > > > > + .min_scale = FRAC_16_16(1, 3), > > > > + .max_scale = FRAC_16_16(10, 1), > > > > + .zpos = 3, > > > > + .watermark = true, > > > > + .color_mgmt = true, > > > > + .roi = true, > > > > + }, > > > > + { > > > > + .name = "Overlay_2", > > > > + .id = OVERLAY_PLANE_2, > > > > + .type = DRM_PLANE_TYPE_OVERLAY, > > > > + .num_formats = ARRAY_SIZE(primary_overlay_format0), > > > > + .formats = primary_overlay_format0, > > > > + .num_modifiers = ARRAY_SIZE(format_modifier0), > > > > + .modifiers = format_modifier0, > > > > + .min_width = 0, > > > > + .min_height = 0, > > > > + .max_width = 4096, > > > > + .max_height = 4096, > > > > + .rotation = DRM_MODE_ROTATE_0 | > > > > + DRM_MODE_ROTATE_90 | > > > > + DRM_MODE_ROTATE_180 | > > > > + DRM_MODE_ROTATE_270 | > > > > + DRM_MODE_REFLECT_X | > > > > + DRM_MODE_REFLECT_Y, > > > > + .blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) | > > > > + BIT(DRM_MODE_BLEND_PREMULTI) | > > > > + BIT(DRM_MODE_BLEND_COVERAGE), > > > > + .color_encoding = BIT(DRM_COLOR_YCBCR_BT709) | > > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > > + .degamma_size = DEGAMMA_SIZE, > > > > + .min_scale = FRAC_16_16(1, 3), > > > > + .max_scale = FRAC_16_16(10, 1), > > > > + .zpos = 4, > > > > + .watermark = true, > > > > + .color_mgmt = true, > > > > + .roi = true, > > > > + }, > > > > + { > > > > + .name = "Overlay_3", > > > > + .id = OVERLAY_PLANE_3, > > > > + .type = DRM_PLANE_TYPE_OVERLAY, > > > > + .num_formats = ARRAY_SIZE(primary_overlay_format0), > > > > + .formats = primary_overlay_format0, > > > > + .num_modifiers = > ARRAY_SIZE(secondary_format_modifiers), > > > > + .modifiers = secondary_format_modifiers, > > > > + .min_width = 0, > > > > + .min_height = 0, > > > > + .max_width = 4096, > > > > + .max_height = 4096, > > > > + .rotation = 0, > > > > + .blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) | > > > > + BIT(DRM_MODE_BLEND_PREMULTI) | > > > > + BIT(DRM_MODE_BLEND_COVERAGE), > > > > + .color_encoding = BIT(DRM_COLOR_YCBCR_BT709) | > > > > + BIT(DRM_COLOR_YCBCR_BT2020), > > > > + .degamma_size = DEGAMMA_SIZE, > > > > + .min_scale = DRM_PLANE_NO_SCALING, > > > > + .max_scale = DRM_PLANE_NO_SCALING, > > > > + .zpos = 5, > > > > + .watermark = true, > > > > + .color_mgmt = true, > > > > + .roi = true, > > > > + }, > > > > + { > > > > + .name = "Cursor", > > > > + .id = CURSOR_PLANE_0, > > > > + .type = DRM_PLANE_TYPE_CURSOR, > > > > + .num_formats = ARRAY_SIZE(cursor_formats), > > > > + .formats = cursor_formats, > > > > + .num_modifiers = 0, > > > > + .modifiers = NULL, > > > > + .min_width = 32, > > > > + .min_height = 32, > > > > + .max_width = 64, > > > > + .max_height = 64, > > > > + .rotation = 0, > > > > + .degamma_size = 0, > > > > + .min_scale = DRM_PLANE_NO_SCALING, > > > > + .max_scale = DRM_PLANE_NO_SCALING, > > > > + .zpos = 255, > > > > + .watermark = false, > > > > + .color_mgmt = false, > > > > + .roi = false, > > > > + }, > > > > + { > > > > + .name = "Cursor_1", > > > > + .id = CURSOR_PLANE_1, > > > > + .type = DRM_PLANE_TYPE_CURSOR, > > > > + .num_formats = ARRAY_SIZE(cursor_formats), > > > > + .formats = cursor_formats, > > > > + .num_modifiers = 0, > > > > + .modifiers = NULL, > > > > + .min_width = 32, > > > > + .min_height = 32, > > > > + .max_width = 64, > > > > + .max_height = 64, > > > > + .rotation = 0, > > > > + .degamma_size = 0, > > > > + .min_scale = DRM_PLANE_NO_SCALING, > > > > + .max_scale = DRM_PLANE_NO_SCALING, > > > > + .zpos = 255, > > > > + .watermark = false, > > > > + .color_mgmt = false, > > > > + .roi = false, > > > > + }, > > > > +}; > > > > + > > > > +static const struct vs_dc_info dc8200_info = { > > > > + .name = "DC8200", > > > > + .panel_num = 2, > > > > + .plane_num = 8, > > > > + .planes = dc_hw_planes_rev0, > > > > + .layer_num = 6, > > > > + .max_bpc = 10, > > > > + .color_formats = DRM_COLOR_FORMAT_RGB444 | > > > > + DRM_COLOR_FORMAT_YCBCR444 | > > > > + DRM_COLOR_FORMAT_YCBCR422 | > > > > + DRM_COLOR_FORMAT_YCBCR420, > > > > + .gamma_size = GAMMA_EX_SIZE, > > > > + .gamma_bits = 12, > > > > + .pitch_alignment = 128, > > > > + .pipe_sync = false, > > > > + .background = true, > > > > + .panel_sync = true, > > > > + .cap_dec = true, > > > > +}; > > > > > > I really think that entire thing is to workaround a suboptimal device tree > binding. > > > You should have two CRTCs in the device tree, you'll probe twice, > > > and you won't get to do that whole dance. > > > > > > I tried to modify it according to this idea Found it too difficult In > > terms of hardware, the two crtc designs are too close to separate, and > > they are even designed into the same reg with different bits > > representing crtc0 and crtc1. It seems not easy to described the 2 > > ctrc hardware by 2 device nodes > > What are these bits doing? <o:p> </o:p> <img border="0" width="810" height="449" style="width:8.4375in;height:4.677in" id="Picture_x0020_1" src="cid:image001.png@01DA54F5.ECEA9C10"><o:p></o:p> For example:<o:p></o:p> like this , bit0 and bit1 match ctrc0 and crtc1 , it is used to start crtc<o:p></o:p> A similar situation exists for other register definitions.<o:p></o:p> <o:p> </o:p> Another case is that ctrc0 and crtc1 have the same function and their offset is continuous, <o:p></o:p> instead of crtc0 being a continuous area, crtc1 being a continuous area<o:p></o:p> reg:<o:p></o:p> crtc0 X<o:p></o:p> crtc1 X+4<o:p></o:p> crtc0 X+8<o:p></o:p> crtc1 X+12<o:p></o:p> if to make it two separate devices, the device node dts reg attribute would be complex<o:p></o:p> <o:p> </o:p> > > > The idea is to avoid a whole dance I don't know if I understand > > correctly about whole dance. Is it means I create 2 ctrc and 8 plane > > in the dc_bind? > > Yeah, you should strive to make it two separate devices. > > Maxime </div> </body> </html>