<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi David,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks for fixing <span class="gmail_default" style="font-family:arial,helvetica,sans-serif"></span>drivers/rtc/lib_test.c</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Best wishes,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Cassio.</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 21 Feb 2024 at 09:28, David Gow <<a href="mailto:davidgow@google.com">davidgow@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">'days' is a s64 (from div_s64), and so should use a %lld specifier.<br>
<br>
This was found by extending KUnit's assertion macros to use gcc's<br>
__printf attribute.<br>
<br>
Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add tests.")<br>
Signed-off-by: David Gow <<a href="mailto:davidgow@google.com" target="_blank">davidgow@google.com</a>><br>
---<br>
 drivers/rtc/lib_test.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/rtc/lib_test.c b/drivers/rtc/lib_test.c<br>
index d5caf36c56cd..225c859d6da5 100644<br>
--- a/<span class="gmail_default" style="font-family:arial,helvetica,sans-serif"></span>drivers/rtc/lib_test.c<br>
+++ b/drivers/rtc/lib_test.c<br>
@@ -54,7 +54,7 @@ static void rtc_time64_to_tm_test_date_range(struct kunit *test)<br>
<br>
                days = div_s64(secs, 86400);<br>
<br>
-               #define FAIL_MSG "%d/%02d/%02d (%2d) : %ld", \<br>
+               #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \<br>
                        year, month, mday, yday, days<br>
<br>
                KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);<br>
-- <br>
2.44.0.rc0.258.g7320e95886-goog<br>
<br>
</blockquote></div></div>