<html><body><p>
<pre>
Hi, Justin:
On Thu, 2024-03-07 at 13:00 -0500, Justin Green wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> Add a check to mtk_drm_gem_init if we attempt to allocate a GEM
> object
> of 0 bytes. Currently, no such check exists and the kernel will panic
> if
> a userspace application attempts to allocate a 0x0 GBM buffer.
>
> Tested by attempting to allocate a 0x0 GBM buffer on an MT8188 and
> verifying that we now return EINVAL.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC
> MT8173.")
> Signed-off-by: Justin green <greenjustin@chromium.org>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index 4f2e3feabc0f..ee49367b6138 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -38,6 +38,9 @@ static struct mtk_drm_gem_obj
> *mtk_drm_gem_init(struct drm_device *dev,
>
> size = round_up(size, PAGE_SIZE);
>
> + if (size == 0)
> +return ERR_PTR(-EINVAL);
> +
> mtk_gem_obj = kzalloc(sizeof(*mtk_gem_obj), GFP_KERNEL);
> if (!mtk_gem_obj)
> return ERR_PTR(-ENOMEM);
> --
> 2.44.0.278.ge034bb2e1d-goog
>
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->