<html><body><p>
<pre>
Hi, Shuijing:
On Fri, 2024-03-15 at 15:29 +0800, Shuijing Li wrote:
> This patch correct calculation formula of PHY timing.
> Make actual phy timing more accurate.
Please define what is accurate and how much this patch improve. For
example, the spec define event 2 happen after event 1 and the duration
between event 1 and event 2 should be from 50us to 100us. But current
duration is 60us and is near the boundary. So this patch make the
duration to 70us so it is near the safe range.
Regards,
CK
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 33 +++++++++++++++-------------
> --
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index a2fdfc8ddb15..d1bd7d671880 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -235,22 +235,23 @@ static void mtk_dsi_phy_timconfig(struct
> mtk_dsi *dsi)
> u32 data_rate_mhz = DIV_ROUND_UP(dsi->data_rate, 1000000);
> struct mtk_phy_timing *timing = &dsi->phy_timing;
>
> -timing->lpx = (60 * data_rate_mhz / (8 * 1000)) + 1;
> -timing->da_hs_prepare = (80 * data_rate_mhz + 4 * 1000) / 8000;
> -timing->da_hs_zero = (170 * data_rate_mhz + 10 * 1000) / 8000 +
> 1 -
> - timing->da_hs_prepare;
> -timing->da_hs_trail = timing->da_hs_prepare + 1;
> -
> -timing->ta_go = 4 * timing->lpx - 2;
> -timing->ta_sure = timing->lpx + 2;
> -timing->ta_get = 4 * timing->lpx;
> -timing->da_hs_exit = 2 * timing->lpx + 1;
> -
> -timing->clk_hs_prepare = 70 * data_rate_mhz / (8 * 1000);
> -timing->clk_hs_post = timing->clk_hs_prepare + 8;
> -timing->clk_hs_trail = timing->clk_hs_prepare;
> -timing->clk_hs_zero = timing->clk_hs_trail * 4;
> -timing->clk_hs_exit = 2 * timing->clk_hs_trail;
> +timing->lpx = (80 * data_rate_mhz / (8 * 1000)) + 1;
> +timing->da_hs_prepare = (59 * data_rate_mhz + 4 * 1000) / 8000
> + 1;
> +timing->da_hs_zero = (163 * data_rate_mhz + 11 * 1000) / 8000 +
> 1 -
> +timing->da_hs_prepare;
> +timing->da_hs_trail = (78 * data_rate_mhz + 7 * 1000) / 8000 +
> 1;
> +
> +timing->ta_go = 4 * timing->lpx;
> +timing->ta_sure = 3 * timing->lpx / 2;
> +timing->ta_get = 5 * timing->lpx;
> +timing->da_hs_exit = (118 * data_rate_mhz / (8 * 1000)) + 1;
> +
> +timing->clk_hs_prepare = (57 * data_rate_mhz / (8 * 1000)) + 1;
> +timing->clk_hs_post = (65 * data_rate_mhz + 53 * 1000) / 8000 +
> 1;
> +timing->clk_hs_trail = (78 * data_rate_mhz + 7 * 1000) / 8000 +
> 1;
> +timing->clk_hs_zero = (330 * data_rate_mhz / (8 * 1000)) + 1 -
> +timing->clk_hs_prepare;
> +timing->clk_hs_exit = (118 * data_rate_mhz / (8 * 1000)) + 1;
>
> timcon0 = timing->lpx | timing->da_hs_prepare << 8 |
> timing->da_hs_zero << 16 | timing->da_hs_trail << 24;
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->