<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> Hi, <div class="moz-cite-prefix">On 2024/4/26 14:23, Maxime Ripard wrote: </div> <blockquote type="cite" cite="mid:20240426-married-augmented-mantis-ff7edd@penduick"> <pre class="moz-quote-pre" wrap="">Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On 2024/4/26 03:10, Andy Shevchenko wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On 2024/4/25 22:26, Andy Shevchenko wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. </pre> </blockquote> <pre class="moz-quote-pre" wrap="">You are using the 'seems' here exactly saying that you are not 100% sure. Please allow me to tell you the truth: This patch again has ZERO effect. It fix nothing. And this patch is has the risks to be wrong. </pre> </blockquote> <pre class="moz-quote-pre" wrap="">Huh?! Really, stop commenting the stuff you do not understand. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> I'm actually a professional display drivers developer at the downstream in the past, despite my contribution to upstream is less. But I believe that all panel driver developers know what I'm talking about. So please have take a look at my replies. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Most of the interactions you had in this series has been uncalled for.</pre> </blockquote> <pre>Right, this paragraph is a little bit of not relevant to the technique point involved. My bad. </pre> <blockquote type="cite" cite="mid:20240426-married-augmented-mantis-ff7edd@penduick"> <pre class="moz-quote-pre" wrap=""> You might be against a patch, </pre> </blockquote> <pre>I'm not rejecting, I'm actually appreciate the original motivation of this series. Its motivation is good, as it helps to move things forward. And it is definitely a nice cleanup. </pre> <blockquote type="cite" cite="mid:20240426-married-augmented-mantis-ff7edd@penduick"> <pre class="moz-quote-pre" wrap="">but there's no need to go to such length. </pre> </blockquote> <pre>Yeah, this is my problem. </pre> <blockquote type="cite" cite="mid:20240426-married-augmented-mantis-ff7edd@penduick"> <pre class="moz-quote-pre" wrap=""> As far as I'm concerned, this patch is fine to me in itself, and I don't see anything that would prevent us from merging it. </pre> </blockquote> <pre>And I think you are right, the codes inside the patch is good enough. I would like to respect your decision then. </pre> <blockquote type="cite" cite="mid:20240426-married-augmented-mantis-ff7edd@penduick"> <pre class="moz-quote-pre" wrap=""> Maxime </pre> </blockquote> </body> </html>