<html><body><p>
<pre>
On Fri, 2024-05-10 at 12:09 +0200, AngeloGioacchino Del Regno wrote:
> Il 10/05/24 08:16, Liankun Yang ha scritto:
> > Fix get efuse issue for MT8188 DPTX.
> >
> > Signed-off-by: Liankun Yang <liankun.yang@mediatek.com>
>
> I may agree with this commit, but:
> 1. The commit title is incorrect - I don't see "drm/mediatek:" -
> please look at
> the history to find out the right titles for your commits; and
> 2. The commit description isn't describing anything, you're just
> repeating the
> title: please add a description. What was wrong? What did you fix
> precisely?
> 3. There's no Fixes tag. Please add the relevant one.
>
> Regards,
> Angelo
>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dp.c | 85
> > ++++++++++++++++++++++++++++++-
> > 1 file changed, 84 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> > b/drivers/gpu/drm/mediatek/mtk_dp.c
> > index 2136a596efa1..32b36b63a4e1 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> > @@ -145,6 +145,89 @@ struct mtk_dp_data {
> > u16 audio_m_div2_bit;
> > };
> >
> > +static const struct mtk_dp_efuse_fmt
> > mt8188_dp_efuse_fmt[MTK_DP_CAL_MAX] = {
> > +[MTK_DP_CAL_GLB_BIAS_TRIM] = {
> > +.idx = 0,
> > +.shift = 10,
> > +.mask = 0x1f,
> > +.min_val = 1,
> > +.max_val = 0x1e,
> > +.default_val = 0xf,
> > +},
> > +[MTK_DP_CAL_CLKTX_IMPSE] = {
> > +.idx = 0,
> > +.shift = 15,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_PMOS_0] = {
> > +.idx = 1,
> > +.shift = 0,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_PMOS_1] = {
> > +.idx = 1,
> > +.shift = 8,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_PMOS_2] = {
> > +.idx = 1,
> > +.shift = 16,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_PMOS_3] = {
> > +.idx = 1,
> > +.shift = 24,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_NMOS_0] = {
> > +.idx = 1,
> > +.shift = 4,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_NMOS_1] = {
> > +.idx = 1,
> > +.shift = 12,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_NMOS_2] = {
> > +.idx = 1,
> > +.shift = 20,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +[MTK_DP_CAL_LN_TX_IMPSEL_NMOS_3] = {
> > +.idx = 1,
> > +.shift = 28,
> > +.mask = 0xf,
> > +.min_val = 1,
> > +.max_val = 0xe,
> > +.default_val = 0x8,
> > +},
> > +};
> > +
> > static const struct mtk_dp_efuse_fmt
> > mt8195_edp_efuse_fmt[MTK_DP_CAL_MAX] = {
> > [MTK_DP_CAL_GLB_BIAS_TRIM] = {
> > .idx = 3,
> > @@ -2758,7 +2841,7 @@ static SIMPLE_DEV_PM_OPS(mtk_dp_pm_ops,
> > mtk_dp_suspend, mtk_dp_resume);
> > static const struct mtk_dp_data mt8188_dp_data = {
> > .bridge_type = DRM_MODE_CONNECTOR_DisplayPort,
> > .smc_cmd = MTK_DP_SIP_ATF_VIDEO_UNMUTE,
> > -.efuse_fmt = mt8195_dp_efuse_fmt,
> > +.efuse_fmt = mt8188_dp_efuse_fmt,
> > .audio_supported = true,
> > .audio_pkt_in_hblank_area = true,
> > .audio_m_div2_bit =
> > MT8188_AUDIO_M_CODE_MULT_DIV_SEL_DP_ENC0_P0_DIV_2,
>
> Sorry.I will send the second edition,and fixing the commit title and
> commit description.
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice
********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->