<html><body><p>
<pre>
Hi, Jason:
On Sun, 2024-05-26 at 22:44 +0800, Jason-JH.Lin wrote:
> To support secure video path feature, GCE have to read/write registgers
> in the secure world. GCE will enable the secure access permission to the
> HW who wants to access the secure content buffer.
>
> Add CMDQ secure mailbox driver to make CMDQ client user is able to
> sending their HW settings to the secure world. So that GCE can execute
> all instructions to configure HW in the secure world.
>
> TODO:
> 1. Squash cmdq_sec_task_exec_work() into cmdq_sec_mbox_send_data().
> 2. Call into TEE to query cookie instead of using shared memory in
> cmdq_sec_get_cookie().
> 3. Register shared memory as command buffer instead of copying normal
> command buffer to IWC shared memory.
> 4. Use SOFTDEP to make cmdq_sec_probe later than OPTEE loaded and then
> move cmdq_sec_session_init into cmdq_sec_probe().
> 5. Remove timeout detection in cmdq_sec_session_send().
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> ---
[snip]
> +static int cmdq_sec_irq_notify_start(struct cmdq_sec *cmdq)
> +{
> +int err;
> +dma_addr_t dma_addr;
> +u64 *inst = NULL;
> +
> +if (cmdq->notify_run)
> +return 0;
> +
> +cmdq->notify_clt.dev = cmdq->pdata->mbox->dev;
> +cmdq->notify_clt.rx_callback = cmdq_sec_irq_notify_callback;
> +cmdq->notify_clt.tx_block = false;
> +cmdq->notify_clt.knows_txdone = true;
> +cmdq->notify_chan = mbox_request_channel(&cmdq->notify_clt, 0);
When playing secure video, video decoder driver would have interrupt both in normal world and secure world [1].
I guess cmdq driver could also have both interrupt in normal world and secure world.
If so, it's not necessary to create a channel to wait SW token.
[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20240516122102.16379-20-yunfei.dong@mediatek.com/
Regards,
CK
> +if (IS_ERR(cmdq->notify_chan)) {
> +dev_err(&cmdq->dev, "failed to request channel\n");
> +return -ENODEV;
> +}
> +
> +cmdq->clt_pkt.va_base = kzalloc(PAGE_SIZE, GFP_KERNEL);
> +if (!cmdq->clt_pkt.va_base)
> +return -ENOMEM;
> +
> +cmdq->clt_pkt.buf_size = PAGE_SIZE;
> +
> +dma_addr = dma_map_single(cmdq->pdata->mbox->dev, cmdq->clt_pkt.va_base,
> + cmdq->clt_pkt.buf_size, DMA_TO_DEVICE);
> +if (dma_mapping_error(cmdq->pdata->mbox->dev, dma_addr)) {
> +dev_err(cmdq->pdata->mbox->dev, "dma map failed, size=%lu\n", PAGE_SIZE);
> +kfree(cmdq->clt_pkt.va_base);
> +return -ENOMEM;
> +}
> +cmdq->clt_pkt.pa_base = dma_addr;
> +
> +INIT_WORK(&cmdq->irq_notify_work, cmdq_sec_irq_notify_work);
> +
> +/* generate irq notify loop command */
> +inst = (u64 *)cmdq->clt_pkt.va_base;
> +*inst = CMDQ_WFE_CMD(cmdq->pdata->cmdq_event);
> +inst++;
> +*inst = CMDQ_EOC_CMD;
> +inst++;
> +*inst = CMDQ_JUMP_CMD(cmdq->clt_pkt.pa_base, cmdq->pdata->shift);
> +inst++;
> +cmdq->clt_pkt.cmd_buf_size += CMDQ_INST_SIZE * 3;
> +cmdq->clt_pkt.loop = true;
> +
> +dma_sync_single_for_device(cmdq->pdata->mbox->dev,
> + cmdq->clt_pkt.pa_base,
> + cmdq->clt_pkt.cmd_buf_size,
> + DMA_TO_DEVICE);
> +err = mbox_send_message(cmdq->notify_chan, &cmdq->clt_pkt);
> +mbox_client_txdone(cmdq->notify_chan, 0);
> +if (err < 0) {
> +dev_err(&cmdq->dev, "%s failed:%d", __func__, err);
> +dma_unmap_single(cmdq->pdata->mbox->dev, cmdq->clt_pkt.pa_base,
> + cmdq->clt_pkt.buf_size, DMA_TO_DEVICE);
> +kfree(cmdq->clt_pkt.va_base);
> +mbox_free_channel(cmdq->notify_chan);
> +
> +return err;
> +}
> +
> +cmdq->notify_run = true;
> +dev_dbg(&cmdq->dev, "%s success!", __func__);
> +
> +return 0;
> +}
> +
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->