<html><body><p>
<pre>
Hi, Shuijing:
On Thu, 2024-08-01 at 16:11 +0800, Shuijing Li wrote:
> Adding the per-frame lp function of mt8188, which can keep HFP in HS and
> reduce the time required for each line to enter and exit low power.
> Per Frame LP:
> |<----------One Active Frame-------->|
> --______________________________________----___________________
> ^HSA+HBP^^RGB^^HFP^^HSA+HBP^^RGB^^HFP^ ^HSA+HBP^^RGB^^HFP^
>
> Per Line LP:
> |<---------------One Active Frame----------->|
> --______________--______________--______________----______________
> ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> ---
[snip]
>
> +static void mtk_dsi_config_vdo_timing_per_frame_lp(struct mtk_dsi *dsi)
> +{
> +u32 horizontal_sync_active_byte;
> +u32 horizontal_backporch_byte;
> +u32 horizontal_frontporch_byte;
> +u32 dsi_tmp_buf_bpp;
> +unsigned int lpx, da_hs_exit, da_hs_prep, da_hs_trail;
> +unsigned int da_hs_zero, ps_wc, hs_vb_ps_wc;
> +u32 v_active_roundup, hstx_cklp_wc;
> +u32 hstx_cklp_wc_max, hstx_cklp_wc_min;
> +struct videomode *vm = &dsi->vm;
> +
> +if (dsi->format == MIPI_DSI_FMT_RGB565)
> +dsi_tmp_buf_bpp = 2;
> +else
> +dsi_tmp_buf_bpp = 3;
> +
> +da_hs_trail = dsi->phy_timing.da_hs_trail;
> +ps_wc = dsi->vm.hactive * dsi_tmp_buf_bpp;
> +
> +if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) {
> +horizontal_sync_active_byte =
> +vm->hsync_len * dsi_tmp_buf_bpp - 10;
> +horizontal_backporch_byte =
> +vm->hback_porch * dsi_tmp_buf_bpp - 10;
> +horizontal_frontporch_byte =
> +vm->hfront_porch * dsi_tmp_buf_bpp - 12;
> +
> +v_active_roundup = (32 + horizontal_sync_active_byte +
> +horizontal_backporch_byte + ps_wc +
> +horizontal_frontporch_byte) % dsi->lanes;
> +if (v_active_roundup)
> +horizontal_backporch_byte = horizontal_backporch_byte +
> +dsi->lanes - v_active_roundup;
> +hstx_cklp_wc_min = (DIV_ROUND_UP((12 + 2 + 4 +
> +horizontal_sync_active_byte), dsi->lanes) + da_hs_trail + 1)
> +* dsi->lanes / 6 - 1;
> +hstx_cklp_wc_max = (DIV_ROUND_UP((20 + 6 + 4 +
> +horizontal_sync_active_byte + horizontal_backporch_byte +
> +ps_wc), dsi->lanes) + da_hs_trail + 1) * dsi->lanes / 6 - 1;
> +} else {
> +horizontal_sync_active_byte = vm->hsync_len * dsi_tmp_buf_bpp - 4;
> +
> +horizontal_backporch_byte = (vm->hback_porch + vm->hsync_len) *
> +dsi_tmp_buf_bpp - 10;
> +hstx_cklp_wc_min = (DIV_ROUND_UP(4, dsi->lanes) + da_hs_trail + 1)
> +* dsi->lanes / 6 - 1;
> +
> +if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
> +horizontal_frontporch_byte = (vm->hfront_porch *
> +dsi_tmp_buf_bpp - 18);
> +
> +v_active_roundup = (28 + horizontal_backporch_byte + ps_wc +
> +horizontal_frontporch_byte) % dsi->lanes;
> +if (v_active_roundup)
> +horizontal_backporch_byte = horizontal_backporch_byte +
> +dsi->lanes - v_active_roundup;
> +
> +hstx_cklp_wc_max = (DIV_ROUND_UP((12 + 4 + 4 +
> +horizontal_backporch_byte + ps_wc),
> +dsi->lanes) + da_hs_trail + 1) * dsi->lanes / 6 - 1;
> +} else {
> +horizontal_frontporch_byte = (vm->hfront_porch *
> +dsi_tmp_buf_bpp - 12);
This function has many duplication. Maybe we could reduce them like this:
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) {
hfp_byte_adjust = 10;
...
} else {
...
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
hfp_byte_adjust = 18;
} else {
hfp_byte_adjust = 12;
}
}
horizontal_frontporch_byte = vm->hfront_porch * dsi_tmp_buf_bpp -
hfp_byte_adjust;
Regards,
CK
> +
> +v_active_roundup = (22 + horizontal_backporch_byte + ps_wc +
> +horizontal_frontporch_byte) % dsi->lanes;
> +if (v_active_roundup)
> +horizontal_backporch_byte = horizontal_backporch_byte +
> +dsi->lanes - v_active_roundup;
> +
> +hstx_cklp_wc_max = (DIV_ROUND_UP((12 + 4 + 4 +
> +horizontal_backporch_byte + ps_wc),
> +dsi->lanes) + da_hs_trail + 1) * dsi->lanes / 6 - 1;
> +}
> +}
> +hstx_cklp_wc = FIELD_GET(HSTX_CKL_WC, readl(dsi->regs + DSI_HSTX_CKL_WC));
> +
> +if (hstx_cklp_wc <= hstx_cklp_wc_min ||
> +hstx_cklp_wc >= hstx_cklp_wc_max) {
> +hstx_cklp_wc = ((hstx_cklp_wc_min + hstx_cklp_wc_max) / 2) << HSTX_CKL_WC_SHIFT;
> +writel(hstx_cklp_wc, dsi->regs + DSI_HSTX_CKL_WC);
> +}
> +hstx_cklp_wc = hstx_cklp_wc >> HSTX_CKL_WC_SHIFT;
> +if (hstx_cklp_wc <= hstx_cklp_wc_min ||
> +hstx_cklp_wc >= hstx_cklp_wc_max) {
> +DRM_WARN("Wrong setting of hstx_ckl_wc\n");
> +}
> +
> +lpx = dsi->phy_timing.lpx;
> +da_hs_exit = dsi->phy_timing.da_hs_exit;
> +da_hs_prep = dsi->phy_timing.da_hs_prepare;
> +da_hs_zero = dsi->phy_timing.da_hs_zero;
> +
> +hs_vb_ps_wc = ps_wc -
> +(lpx + da_hs_exit + da_hs_prep + da_hs_zero + 2)
> +* dsi->lanes;
> +horizontal_frontporch_byte = (1 << HFP_HS_EN)
> +| (hs_vb_ps_wc << HFP_HS_VB_PS_WC_SHIFT)
> +| (horizontal_frontporch_byte);
> +
> +writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC);
> +writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC);
> +writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC);
> +}
> +
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->