<html><body><p>
<pre>
Hi, Shuijing:
On Thu, 2024-08-01 at 16:11 +0800, Shuijing Li wrote:
> Adding the per-frame lp function of mt8188, which can keep HFP in HS and
> reduce the time required for each line to enter and exit low power.
> Per Frame LP:
> |<----------One Active Frame-------->|
> --______________________________________----___________________
> ^HSA+HBP^^RGB^^HFP^^HSA+HBP^^RGB^^HFP^ ^HSA+HBP^^RGB^^HFP^
>
> Per Line LP:
> |<---------------One Active Frame----------->|
> --______________--______________--______________----______________
> ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> ---
[snip]
> +
> static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi)
> {
> u32 horizontal_sync_active_byte;
> @@ -449,57 +560,61 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi)
> writel(vm->vfront_porch, dsi->regs + DSI_VFP_NL);
> writel(vm->vactive, dsi->regs + DSI_VACT_NL);
>
> -if (dsi->driver_data->has_size_ctl)
> -writel(FIELD_PREP(DSI_HEIGHT, vm->vactive) |
> - FIELD_PREP(DSI_WIDTH, vm->hactive),
> - dsi->regs + DSI_SIZE_CON);
> -
> -horizontal_sync_active_byte = (vm->hsync_len * dsi_tmp_buf_bpp - 10);
> -
> -if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
> -horizontal_backporch_byte = vm->hback_porch * dsi_tmp_buf_bpp - 10;
> -else
> -horizontal_backporch_byte = (vm->hback_porch + vm->hsync_len) *
> - dsi_tmp_buf_bpp - 10;
> -
> -data_phy_cycles = timing->lpx + timing->da_hs_prepare +
> - timing->da_hs_zero + timing->da_hs_exit + 3;
> -
> -delta = dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST ? 18 : 12;
> -delta += dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET ? 0 : 2;
> +if (dsi->driver_data->support_per_frame_lp)
> +mtk_dsi_config_vdo_timing_per_frame_lp(dsi);
> +else {
The 'if' part is a function, so I think the 'else' should also be a function because the both part do the similar things.
Regards,
CK
> +if (dsi->driver_data->has_size_ctl)
> +writel(FIELD_PREP(DSI_HEIGHT, vm->vactive) |
> +FIELD_PREP(DSI_WIDTH, vm->hactive),
> +dsi->regs + DSI_SIZE_CON);
>
> -horizontal_frontporch_byte = vm->hfront_porch * dsi_tmp_buf_bpp;
> -horizontal_front_back_byte = horizontal_frontporch_byte + horizontal_backporch_byte;
> -data_phy_cycles_byte = data_phy_cycles * dsi->lanes + delta;
> +horizontal_sync_active_byte = (vm->hsync_len * dsi_tmp_buf_bpp - 10);
>
> -if (horizontal_front_back_byte > data_phy_cycles_byte) {
> -horizontal_frontporch_byte -= data_phy_cycles_byte *
> - horizontal_frontporch_byte /
> - horizontal_front_back_byte;
> -
> -horizontal_backporch_byte -= data_phy_cycles_byte *
> - horizontal_backporch_byte /
> - horizontal_front_back_byte;
> -} else {
> -DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n");
> -}
> -
> -if ((dsi->mode_flags & MIPI_DSI_HS_PKT_END_ALIGNED) &&
> - (dsi->lanes == 4)) {
> -horizontal_sync_active_byte =
> -roundup(horizontal_sync_active_byte, dsi->lanes) - 2;
> -horizontal_frontporch_byte =
> -roundup(horizontal_frontporch_byte, dsi->lanes) - 2;
> -horizontal_backporch_byte =
> -roundup(horizontal_backporch_byte, dsi->lanes) - 2;
> -horizontal_backporch_byte -=
> -(vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes;
> +if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
> +horizontal_backporch_byte = vm->hback_porch * dsi_tmp_buf_bpp - 10;
> +else
> +horizontal_backporch_byte = (vm->hback_porch + vm->hsync_len) *
> +dsi_tmp_buf_bpp - 10;
> +
> +data_phy_cycles = timing->lpx + timing->da_hs_prepare +
> +timing->da_hs_zero + timing->da_hs_exit + 3;
> +
> +delta = dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST ? 18 : 12;
> +delta += dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET ? 0 : 2;
> +
> +horizontal_frontporch_byte = vm->hfront_porch * dsi_tmp_buf_bpp;
> +horizontal_front_back_byte = horizontal_frontporch_byte + horizontal_backporch_byte;
> +data_phy_cycles_byte = data_phy_cycles * dsi->lanes + delta;
> +
> +if (horizontal_front_back_byte > data_phy_cycles_byte) {
> +horizontal_frontporch_byte -= data_phy_cycles_byte *
> +horizontal_frontporch_byte /
> +horizontal_front_back_byte;
> +
> +horizontal_backporch_byte -= data_phy_cycles_byte *
> +horizontal_backporch_byte /
> +horizontal_front_back_byte;
> +} else {
> +DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n");
> +}
> +
> +if ((dsi->mode_flags & MIPI_DSI_HS_PKT_END_ALIGNED) &&
> +(dsi->lanes == 4)) {
> +horizontal_sync_active_byte =
> +roundup(horizontal_sync_active_byte, dsi->lanes) - 2;
> +horizontal_frontporch_byte =
> +roundup(horizontal_frontporch_byte, dsi->lanes) - 2;
> +horizontal_backporch_byte =
> +roundup(horizontal_backporch_byte, dsi->lanes) - 2;
> +horizontal_backporch_byte -=
> +(vm->hactive * dsi_tmp_buf_bpp + 2) % dsi->lanes;
> +}
> +
> +writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC);
> +writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC);
> +writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC);
> }
>
> -writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC);
> -writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC);
> -writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC);
> -
> mtk_dsi_ps_control(dsi, false);
> }
>
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->