<html><body><p> <pre> On Wed, 2024-09-25 at 07:45 +0000, CK Hu (胡俊光) wrote: > > > Hi, Jason: > > On Tue, 2024-09-24 at 09:49 +0800, Jason-JH.Lin wrote: > > OVL_CON_CLRFMT_MAN is a configuration for extending color format > > settings of DISP_REG_OVL_CON(n). > > It will change some of the original color format settings. > > > > Take the settings of (3 << 12) for example. > > - If OVL_CON_CLRFMT_MAN = 0 means OVL_CON_CLRFMT_RGBA8888. > > - If OVL_CON_CLRFMT_MAN = 1 means OVL_CON_CLRFMT_PARGB8888. > > > > Since OVL_CON_CLRFMT_MAN is not supported on previous SoCs, > > It breaks the OVL color format setting of MT8173. > > > > Therefore, the fmt_convert function pointer is added to the driver > > data > > and mtk_ovl_fmt_convert_with_blend is implemented for MT8192 and > > MT8195 > > that support OVL_CON_CLRFMT_MAN, and mtk_ovl_fmt_convert is > > implemented > > for other SoCs that do not support it to solve the degradation > > problem. > > This patch looks good to me, so > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > By this patch, only some SoC support pre-multiplied pixel format. > In [1], it declare that all SoC support pre-multiplied pixel format, > so I think need another patch to let only some SoC support pre- > multiplied. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/mediatek?h=next-20240925&id=4225d5d5e779b859a6661130a3444eb4c5db77e5 > No problem, I'll send another patch to fix [1] in v5 soon. Regards, Jason-JH.Lin </pre> </p></body></html><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>