<html><body><p> <pre> Hi, Shu-hsiang: On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote: > Introduces the ISP pipeline driver for the MediaTek ISP raw and yuv > modules. Key functionalities include data processing, V4L2 integration, > resource management, debug support, and various control operations. > Additionally, IRQ handling, platform device management, and MediaTek > ISP DMA format support are also included. > > Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@mediatek.com> > --- [snip] > + > +/* feature mask to categorize all raw functions */ > +#define MTK_CAM_FEATURE_HDR_MASK0x0000000F > +#define MTK_CAM_FEATURE_SUBSAMPLE_MASK0x000000F0 > +#define MTK_CAM_FEATURE_OFFLINE_M2M_MASK0x00000100 > +#define MTK_CAM_FEATURE_PURE_OFFLINE_M2M_MASK0x00000200 It seems that M2M is not basic function. It's an advanced function, so separate M2M related code to an independent patch. Make the first patch as simple as possible. Regards, CK > + > +enum raw_function_id { > +/* bit [0~3] hdr */ > +/* bit [4~7] fps */ > +/* bit [8~9] m2m */ > +OFFLINE_M2M= (1 << 8), > +PURE_OFFLINE_M2M= (1 << 9), > +RAW_FUNCTION_END= 0xF0000000, > +}; > + </pre> </p></body></html><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>