<html><body><p>
<pre>
On Mon, 2024-10-28 at 13:20 +0800, CK Hu wrote:
> Hi, Shu-hsiang:
>
> On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> > Introduces state management and debugging mechanisms for the MediaTek
> > ISP7.x camsys platform. State management establishes control over ISP
> > operations and events, defining distinct states for request handling,
> > sensor control, and frame synchronization, ensuring event processing.
> > The debugging mechanism ensures stable operation and timely data
> > collection during anomalies.
> >
> > Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@mediatek.com>
> > ---
>
> [snip]
>
> > +int mtk_camsys_isr_event(struct mtk_cam_device *cam,
> > + enum MTK_CAMSYS_ENGINE_TYPE engine_type,
> > + unsigned int engine_id,
> > + struct mtk_camsys_irq_info *irq_info)
> > +{
> > +int ret = 0;
> > +
> > +switch (engine_type) {
> > +case CAMSYS_ENGINE_RAW:
> > +ret = mtk_camsys_event_handle_raw(cam, engine_id, irq_info);
> > +break;
> > +case CAMSYS_ENGINE_SENINF:

CAMSYS_ENGINE_SENINF is also never set, so drop it.

Regards,
CK

> > +if (irq_info->irq_type & (1 << CAMSYS_IRQ_FRAME_DROP))
>
> CAMSYS_IRQ_FRAME_DROP is never set, so drop it.
>
> Regards,
> CK
>
> > +dev_info(cam->dev,
> > + "MTK_CAMSYS_ENGINE_SENINF_TAG engine:%d type:0x%x\n",
> > + engine_id, irq_info->irq_type);
> > +break;
> > +default:
> > +break;
> > +}
> > +
> > +return ret;
> > +}
> > +

</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any 
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be 
conveyed only to the designated recipient(s). Any use, dissemination, 
distribution, printing, retaining or copying of this e-mail (including its 
attachments) by unintended recipient(s) is strictly prohibited and may 
be unlawful. If you are not an intended recipient of this e-mail, or believe 
that you have received this e-mail in error, please notify the sender 
immediately (by replying to this e-mail), delete any and all copies of 
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->