<html><body><p> <pre> Hi, Shu-hsiang: On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote: > Introduces the driver of the MediaTek Sensor Interface, > focusing on integration with the MediaTek ISP CAMSYS. The > seninf device bridges camera sensors and the ISP system, > providing management for sensor data routing and processing. > Key features include V4L2 framework control, and dynamic > handling of stream configurations and virtual channels. > > Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@mediatek.com> > --- [snip] > +static int get_pixel_rate(struct seninf_ctx *ctx, struct v4l2_subdev *sd, > + s64 *result) > +{ > +struct v4l2_ctrl *ctrl; > + > +ctrl = v4l2_ctrl_find(sd->ctrl_handler, V4L2_CID_PIXEL_RATE); V4L2_CID_PIXEL_RATE is never set, so this function is redundant. Drop this function. Regards, CK > +if (!ctrl) { > +dev_info(ctx->dev, "no pixel rate in subdev %s\n", sd->name); > +return -EINVAL; > +} > + > +*result = v4l2_ctrl_g_ctrl_int64(ctrl); > + > +return 0; > +} > + </pre> </p></body></html><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>