<html><body><p>
<pre>
Hi, Shu-hsiang:
On Wed, 2024-11-20 at 10:21 +0800, CK Hu wrote:
> Hi, Shu-hsiang:
>
> On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> > Introduces utility files for the MediaTek ISP7.x camsys driver. These
> > utilities provide essential platform definitions, debugging tools, and
> > management functions to support ISP operations and SCP communication.
> > Key functionalities include:
> > 1.Hardware pipeline and register definitions for managing image
> > processing modules.
> > 2.DMA debugging utilities and buffer management functions.
> > 3.Definitions of supported image formats for proper data handling.
> > 4.IPI and SCP communication structures for module state management and
> > configuring ISP.
> > 5.Metadata parameters for configuring image processing.
> >
> > Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@mediatek.com>
> > ---
>
> [snip]
>
> > +
> > +enum mtkcam_ipi_raw_video_id {
>
> It's better to use 'scp' instead of 'ipi'.
> The interface is provided by scp.
> ipi just transfer data between mtkcam and scp and ipi does not care the data content.
Forget my previous comment.
I find the scp command is SCP_IPI_ISP_CMD or SCP_IPI_ISP_FRAME.
So maybe the prefix should be scp_ipi_isp so some shorter symbol like isp.
Regards,
CK
>
> > +MTKCAM_IPI_RAW_ID_UNKNOWN= 0,
>
> Ditto.
>
> > +MTKCAM_IPI_RAW_RAWI_2,/* RAWI_R2 */
>
> Ditto.
>
> > +MTKCAM_IPI_RAW_RAWI_3,/* RAWI_R3 */
>
> Ditto.
>
> > +MTKCAM_IPI_RAW_RAWI_5,/* RAWI_R5 */
>
> Ditto.
>
> > +MTKCAM_IPI_RAW_RAWI_6,/* RAWI_R6 */
> > +MTKCAM_IPI_RAW_IMGO,/* IMGO_R1 */
> > +MTKCAM_IPI_RAW_UFEO,/* UFEO_R1 */
> > +MTKCAM_IPI_RAW_RRZO,/* RRZO_R1 */
> > +MTKCAM_IPI_RAW_UFGO,/* UFGO_R1 */
> > +MTKCAM_IPI_RAW_YUVO_1,/* YUVO_R1 */
> > +MTKCAM_IPI_RAW_YUVO_2,/* YUVO_R2 */
> > +MTKCAM_IPI_RAW_YUVO_3,/* YUVO_R3 */
> > +MTKCAM_IPI_RAW_YUVO_4,/* YUVO_R4 */
> > +MTKCAM_IPI_RAW_YUVO_5,/* YUVO_R5 */
> > +MTKCAM_IPI_RAW_RZH1N2TO_2,/* RZH1N2TO_R2 */
> > +MTKCAM_IPI_RAW_DRZS4NO_1,/* DRZS4NO_R1 */
> > +MTKCAM_IPI_RAW_DRZS4NO_2,/* DRZS4NO_R2 */
> > +MTKCAM_IPI_RAW_DRZS4NO_3,/* DRZS4NO_R3 */
> > +MTKCAM_IPI_RAW_RZH1N2TO_3,/* RZH1N2TO_R3 */
> > +MTKCAM_IPI_RAW_RZH1N2TO_1,/* RZH1N2TO_R1 */
> > +MTKCAM_IPI_RAW_META_STATS_CFG,/* All settings */
> > +MTKCAM_IPI_RAW_META_STATS_0,/* statistics */
> > +
> > +/*
> > + * MTKCAM_IPI_RAW_META_STATS_1 is for AFO only, the buffer can be
> > + * dequeued once we got the dma done.
> > + */
> > +MTKCAM_IPI_RAW_META_STATS_1,
> > +
> > +/* statistics may be pass to DIP */
> > +MTKCAM_IPI_RAW_META_STATS_2,
> > +MTKCAM_IPI_RAW_ID_MAX,
> > +};
> > +
> > +/* Supported bayer pixel order */
> > +enum mtkcam_ipi_bayer_pxl_id {
>
> Ditto.
>
> Regards,
> CK
>
> > +MTKCAM_IPI_BAYER_PXL_ID_B= 0,
> > +MTKCAM_IPI_BAYER_PXL_ID_GB= 1,
> > +MTKCAM_IPI_BAYER_PXL_ID_GR= 2,
> > +MTKCAM_IPI_BAYER_PXL_ID_R= 3,
> > +MTKCAM_IPI_BAYER_PXL_ID_UNKNOWN= 4,
> > +};
> > +
>
>
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->