<html><body><p> <pre> On Thu, 2024-11-21 at 12:48 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 21/11/2024 11:51, Jason-JH Lin (林睿祥) wrote: > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > > > --- > > > > .../dt-bindings/mailbox/mediatek,mt8196-gce.h | 1449 > > > > +++++++++++++++++ > > > > 1 file changed, 1449 insertions(+) > > > > create mode 100755 include/dt- > > > > bindings/mailbox/mediatek,mt8196- > > > > gce.h > > > > > > Please run scripts/checkpatch.pl and fix reported warnings. Then > > > please > > > run 'scripts/checkpatch.pl --strict' and (probably) fix more > > > warnings. > > > Some warnings can be ignored, especially from --strict run, but > > > the > > > code > > > here looks like it needs a fix. Feel free to get in touch if the > > > warning > > > is not clear. > > > > > > This goes with the binding. > > > > > > > I thought I have done that, but I found a whitespace warning at > > #1328 > > now. I'll fix that at the next version. > > Thanks for the reminder. > > There are multiple errors, including executable permission. I don't > believe you run checkpatch. Oh, my bad. You're right. I have checked the history and found I missed this patch... ~/linux$ ./scripts/checkpatch.pl --strict --ignore=GERRIT_CHANGE_ID -- show-types 000* --------------------------------------------------------------- 0001-mailbox-mtk-cmdq-Add-driver-data-to-support-for-MT81.patch --------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 223 lines checked 0001-mailbox-mtk-cmdq-Add-driver-data-to-support-for-MT81.patch has no obvious style problems and is ready for submission. --------------------------------------------------------------- 0002-soc-mediatek-mtk-cmdq-Add-unsupported-subsys-ID-prog.patch --------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 261 lines checked 0002-soc-mediatek-mtk-cmdq-Add-unsupported-subsys-ID-prog.patch has no obvious style problems and is ready for submission. --------------------------------------------------------------- 0003-soc-mediatek-mtk-cmdq-Add-mminfra_offset-compatibili.patch --------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 97 lines checked 0003-soc-mediatek-mtk-cmdq-Add-mminfra_offset-compatibili.patch has no obvious style problems and is ready for submission. ---------------------------------------------------------- 0004-soc-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch ---------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 15 lines checked 0004-soc-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch has no obvious style problems and is ready for submission. ---------------------------------------------------------- 0005-drm-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch ---------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 24 lines checked 0005-drm-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch has no obvious style problems and is ready for submission. --------------------------------------------------------------- 0006-media-mediatek-mdp3-Add-pa_base-due-to-CMDQ-API-chan.patch --------------------------------------------------------------- total: 0 errors, 0 warnings, 0 checks, 32 lines checked 0006-media-mediatek-mdp3-Add-pa_base-due-to-CMDQ-API-chan.patch has no obvious style problems and is ready for submission. Due to some IT policy, I run checkpatch and sent these patches in 2 different servers. I have added it back and run checkpatch. Thanks! Regards, Jason-JH.Lin > > Best regards, > Krzysztof </pre> </p></body></html><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>