<html><body><p>
<pre>
Hi, Angelo:
On Wed, 2024-11-20 at 13:45 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> Add support for the newer HDMI-TX (Encoder) v2 and DDC v2 IPs
> found in MediaTek's MT8195, MT8188 SoC and their variants, and
> including support for display modes up to 4k60 and for HDMI
> Audio, as per the HDMI 2.0 spec.
>
> HDCP and CEC functionalities are also supported by this hardware,
> but are not included in this commit.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
[snip]
> +static const struct drm_edid *mtk_hdmi_v2_bridge_edid_read(struct drm_bridge *bridge,
> + struct drm_connector *connector)
> +{
This function is identical to v1, so make edid read as common function.
Regards,
CK
> + struct mtk_hdmi *hdmi = hdmi_ctx_from_bridge(bridge);
> + const struct drm_edid *drm_edid;
> +
> + if (!hdmi->ddc_adpt)
> + return NULL;
> +
> + drm_edid = drm_edid_read_ddc(connector, hdmi->ddc_adpt);
> + if (drm_edid) {
> + /*
> + * This should use !connector->display_info.has_audio (or
> + * !connector->display_info.is_hdmi) from a path that has read
> + * the EDID and called drm_edid_connector_update().
> + */
> + const struct edid *edid = drm_edid_raw(drm_edid);
> +
> + hdmi->dvi_mode = !drm_detect_monitor_audio(edid);
> + }
> +
> + return drm_edid;
> +}
> +
>
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->