<html><body><p> <pre> Hi Pin-yen, Thanks for the reviews. On Fri, 2024-12-13 at 11:41 +0800, Pin-yen Lin wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Hi Jason, > > On Thu, Dec 12, 2024 at 11:33 PM Jason-JH.Lin < > jason-jh.lin@mediatek.com> wrote: > > > > From: Hsiao Chien Sung <shawn.sung@mediatek.com> > > > > Modify rules for both MT8195 and MT8188. > > Hardware capabilities include color formats and AFBC are > > changed since MT8195, stop using the settings of MT8183. > > > > Acked-by: Rob Herring <robh@kernel.org> > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > --- > > .../bindings/display/mediatek/mediatek,ovl.yaml | 8 +++- > > ---- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y > > aml > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y > > aml > > index 9ea796a033b2..0ace12bbb623 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y > > aml > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y > > aml > > @@ -36,16 +36,14 @@ properties: > > - enum: > > - mediatek,mt6795-disp-ovl > > - const: mediatek,mt8173-disp-ovl > > - - items: > > - - enum: > > - - mediatek,mt8188-disp-ovl > > - - mediatek,mt8195-disp-ovl > > - - const: mediatek,mt8183-disp-ovl > > This breaks the schema check for mt8195.dtsi, which is currently > using > `compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp- > ovl";` > > IIUC this is supposed to be a RESEND of [1], which actually added a > binding for "mediatek,mt8195-disp-ovl". However [1] still breaks > mt8195.dtsi because it only allows `compatible = > "mediatek,mt8195-disp-ovl"` But not `compatible = > "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl"`. > Yes, I lost the "mediatek,mt8195-disp-ovl" in [1] at the beginning of compatible property. I'll add it to the next version. > If "mediatek,mt8183-disp-ovl" is a reasonable fallback for > "mediatek,mt8195-disp-ovl", please keep a binding like: > > - items: > - const: mediatek,mt8195-disp-ovl > - const: mediatek,mt8183-disp-ovl > > Or, fix mt8195.dtsi instead in the same series. Yes, I think the OVL in mt8195.dtsi should remove the "mediatek,mt8183- disp-ovl" because it's not compatible anymore. I'll add that path in the same series. Regards, Jason-JH.Lin </pre> </p></body></html><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>