<html><body><p> <pre> Hi, Angelo: On Tue, 2024-12-17 at 16:43 +0100, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > The hdmi_colorspace csp member of struct mtk_hdmi is initialized > once but then it's never used at all. > Remove said member and the only assignment to it as a cleanup. > > Also remove the ibias, ibias_up, min_clock, max_clock, min_hdisplay > and max_vdisplay members, as those were really completely unused. > > This commit brings no functional changes. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index c95c7b55998c..3ecd0ed59851 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -162,16 +162,9 @@ struct mtk_hdmi { > struct clk *clk[MTK_HDMI_CLK_COUNT]; > struct drm_display_mode mode; > bool dvi_mode; > - u32 min_clock; > - u32 max_clock; > - u32 max_hdisplay; > - u32 max_vdisplay; > - u32 ibias; > - u32 ibias_up; > struct regmap *sys_regmap; > unsigned int sys_offset; > struct regmap *regs; > - enum hdmi_colorspace csp; > struct platform_device *audio_pdev; > struct hdmi_audio_param aud_param; > bool audio_enable; > @@ -1036,7 +1029,6 @@ static int mtk_hdmi_output_init(struct mtk_hdmi *hdmi) > { > struct hdmi_audio_param *aud_param = &hdmi->aud_param; > > - hdmi->csp = HDMI_COLORSPACE_RGB; > aud_param->aud_codec = HDMI_AUDIO_CODING_TYPE_PCM; > aud_param->aud_sample_size = HDMI_AUDIO_SAMPLE_SIZE_16; > aud_param->aud_input_type = HDMI_AUD_INPUT_I2S; > -- > 2.47.0 > </pre> </p></body></html><pre>************* MEDIATEK Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! </pre>