<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hey all,<o:p></o:p> <o:p> </o:p> For one of our new boards I have to get the ADV7513 chip working with TIDSS, the driver for this expects a bridge chip to have atomic ops and provide bus formats.<o:p></o:p> Doing this for our own needs was quite straightforward but I’d very much like to upstream this as I think it could be helpful for others as well,<o:p></o:p> I do have some questions I hope to get some answers on that could help me in writing an initial patch.<o:p></o:p> I hope you’ll forgive any ignorance on my end as it’s my first foray into DRI.<o:p></o:p> <o:p> </o:p> - For all needed atomic ops I added the drm atomic ops helpers, except for atomic_check, looking through the<o:p></o:p> other implementations I can’t quite figure out what I’m expected to implement here, what is the expectation for<o:p></o:p> this function?<o:p></o:p> - Looking at the lontium 9611, only the input bus formats bridge function are added there, which seems sensible <o:p></o:p> as the output goes out straight over HDMI, is it a correct assumption I’d only have to add the input bus formats for<o:p></o:p> the adv7511 driver? Part of me thinks this might not necessarily be correct as it seems the chip can be chained further<o:p></o:p> than merely to a connector and I’m not sure what this would (or could) expect<o:p></o:p> - Does Input justification matter for the bus format? My assumption is that left/evenly/right does not matter for the<o:p></o:p> format as it only relates to which pins are used and it’s e.g. MEDIA_BUS_FMT_UYVY8_2X8 no matter which pins this is placed at<o:p></o:p> so I should just focus on the actively used pins.<o:p></o:p> - As it’s a common driver for adv7511(w)/adv7513, would anyone know if they all use the exact same types of input styles<o:p></o:p> (of course with varying color depth support) so that I could use ADV7511 as a sort of superset for all possibilities and work<o:p></o:p> from there to define all the input formats?<o:p></o:p> - There seem to be certain formats in there that don’t exist yet, such as YUV444 12-bit VYU (if I do this right and read highest data bits to lowest,<o:p></o:p> which I assume translates to MEDIA_BUS_FMT_VYU12_1X36), should I just write a patch for all missing formats to the uapi media-bus-format header<o:p></o:p> or is there anything else to take into consideration?<o:p></o:p> <o:p> </o:p> Best regards,<o:p></o:p> Jesse<o:p></o:p> </div> </body> </html>