<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Jan 29, 2025 at 8:18 AM Dave Stevenson <<a href="mailto:dave.stevenson@raspberrypi.com">dave.stevenson@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Anusha<br>
<br>
On Tue, 28 Jan 2025 at 22:33, Anusha Srivatsa <<a href="mailto:asrivats@redhat.com" target="_blank">asrivats@redhat.com</a>> wrote:<br>
><br>
> Replace platform_get_resource_byname + devm_ioremap_resource<br>
> with just devm_platform_ioremap_resource()<br>
><br>
> Used Coccinelle to do this change. SmPl patch:<br>
> //rule s/(devm_)platform_get_resource_byname +<br>
> //(devm_)ioremap/devm_platform_ioremap_resource.<br>
> @rule_3@<br>
> identifier res;<br>
> expression ioremap;<br>
> identifier pdev;<br>
> constant mem;<br>
> expression name;<br>
> @@<br>
> -struct resource *res;<br>
> ...<br>
> -res = platform_get_resource_byname(pdev,mem,name);<br>
> <...<br>
> -if (!res) {<br>
> -...<br>
> -}<br>
> ...><br>
> -ioremap = devm_ioremap(...);<br>
> +ioremap = devm_platform_ioremap_resource_byname(pdev,name);<br>
><br>
> Cc: Maxime Ripard <<a href="mailto:mripard@kernel.org" target="_blank">mripard@kernel.org</a>><br>
> Cc: Dave Stevenson <<a href="mailto:dave.stevenson@raspberrypi.com" target="_blank">dave.stevenson@raspberrypi.com</a>><br>
> Cc: "Maíra Canal" <<a href="mailto:mcanal@igalia.com" target="_blank">mcanal@igalia.com</a>><br>
> Signed-off-by: Anusha Srivatsa <<a href="mailto:asrivats@redhat.com" target="_blank">asrivats@redhat.com</a>><br>
> ---<br>
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 9 ++-------<br>
>  1 file changed, 2 insertions(+), 7 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c<br>
> index 47d9ada98430634cfd8c1e21c2a4d00d501bab7e..e22733f8159aa4b247a915e24a236f620bae932c 100644<br>
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c<br>
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c<br>
> @@ -2951,15 +2951,10 @@ static int vc5_hdmi_init_resources(struct drm_device *drm,<br>
>  {<br>
>         struct platform_device *pdev = vc4_hdmi->pdev;<br>
>         struct device *dev = &pdev->dev;<br>
> -       struct resource *res;<br>
>         int ret;<br>
><br>
> -       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hdmi");<br>
> -       if (!res)<br>
> -               return -ENODEV;<br>
> -<br>
> -       vc4_hdmi->hdmicore_regs = devm_ioremap(dev, res->start,<br>
> -                                              resource_size(res));<br>
> +       vc4_hdmi->hdmicore_regs = devm_platform_ioremap_resource_byname(pdev,<br>
> +                                                                       "hdmi");<br>
<br>
Whilst I totally agree with this change, why was only one of the 8<br>
instances of this pattern within this function updated? Is that a<br>
limitation in your script?<br>
<a href="https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/vc4/vc4_hdmi.c#L2957-L3020" rel="noreferrer" target="_blank">https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/vc4/vc4_hdmi.c#L2957-L3020</a><br>
<br></blockquote><div><br></div><div>Yes! looks like it is. My script is missing one set of ellipses which makes it apply the rule only to the first appearance of the pattern. Will rectify this. Thanks!!</div><div><br></div><div>Anusha<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  Dave<br>
<br>
>         if (!vc4_hdmi->hdmicore_regs)<br>
>                 return -ENOMEM;<br>
><br>
><br>
> --<br>
> 2.47.0<br>
><br>
<br>
</blockquote></div></div>