<html><body><p>
<pre>
On Tue, 2025-02-11 at 17:54 +0000, Conor Dooley wrote:
> On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> > Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> >
> > Signed-off-by: Sunny Shen <sunny.shen@mediatek.com>
> > ---
> > .../display/mediatek/mediatek,mdp-rsz.yaml | 46
> > +++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > new file mode 100644
> > index 000000000000..6642b9aa651a
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rsz.yaml#
>
> Filename matching compatible please
Got it
will modify the compatible to "mediatek,mt8196-mdp-rsz"
>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek display multimedia data path resizer
> > +
> > +maintainers:
> > + - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > + - Philipp Zabel <p.zabel@pengutronix.de>
> > +
> > +description: |
> > + MediaTek display multimedia data path resizer, namely MDP-RSZ,
> > + can do scaling up/down to the picture.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8196-disp-mdp-rsz
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: MDP-RSZ Clock
>
> This can just be "maxItems: 1"
OK, will modify this
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
>
> And "disp-mdp-rsz0" isn't anything close to a generic node name.
Will modify "disp-mdp-rsz0@321a0000" to "mdp-rsz@321a0000"
>
> > + compatible = "mediatek,mt8196-disp-mdp-rsz";
> > + reg = <0 0x321a0000 0 0x1000>;
> > + clocks = <&dispsys_config_clk 101>;
>
> Surprised there are so few properties, no ports link or anything like
> that?
Because the mt8196's path mux design, we use mdp-rsz as a bypass mode
hw.
So only set the basic properties.
>
> > + };
> > + };
> > --
> > 2.34.1
> >
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->