<div dir="ltr"><div>Reviewed-by: Anusha Srivatsa <<a href="mailto:asrivats@redhat.com">asrivats@redhat.com</a>></div><div><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Feb 26, 2025 at 12:28 PM Thomas Zimmermann <<a href="mailto:tzimmermann@suse.de">tzimmermann@suse.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Avoid dereferencing struct drm_gem_object.import_attach for the<br>
imported dma-buf. The dma_buf field in the GEM object instance refers<br>
to the same buffer. Prepares to make import_attach optional.<br>
<br>
Signed-off-by: Thomas Zimmermann <<a href="mailto:tzimmermann@suse.de" target="_blank">tzimmermann@suse.de</a>><br>
---<br>
drivers/gpu/drm/drm_gem_shmem_helper.c | 6 +++---<br>
1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c<br>
index 7722cd720248..d99dee67353a 100644<br>
--- a/drivers/gpu/drm/drm_gem_shmem_helper.c<br>
+++ b/drivers/gpu/drm/drm_gem_shmem_helper.c<br>
@@ -339,10 +339,10 @@ int drm_gem_shmem_vmap(struct drm_gem_shmem_object *shmem,<br>
int ret = 0;<br>
<br>
if (drm_gem_is_imported(obj)) {<br>
- ret = dma_buf_vmap(obj->import_attach->dmabuf, map);<br>
+ ret = dma_buf_vmap(obj->dma_buf, map);<br>
if (!ret) {<br>
if (drm_WARN_ON(obj->dev, map->is_iomem)) {<br>
- dma_buf_vunmap(obj->import_attach->dmabuf, map);<br>
+ dma_buf_vunmap(obj->dma_buf, map);<br>
return -EIO;<br>
}<br>
}<br>
@@ -405,7 +405,7 @@ void drm_gem_shmem_vunmap(struct drm_gem_shmem_object *shmem,<br>
struct drm_gem_object *obj = &shmem->base;<br>
<br>
if (drm_gem_is_imported(obj)) {<br>
- dma_buf_vunmap(obj->import_attach->dmabuf, map);<br>
+ dma_buf_vunmap(obj->dma_buf, map);<br>
} else {<br>
dma_resv_assert_held(shmem->base.resv);<br>
<br>
-- <br>
2.48.1<br>
<br>
</blockquote></div></div>