<div dir="ltr"><div>Reviewed-by: Anusha Srivatsa <<a href="mailto:asrivats@redhat.com">asrivats@redhat.com</a>></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Feb 26, 2025 at 12:28 PM Thomas Zimmermann <<a href="mailto:tzimmermann@suse.de">tzimmermann@suse.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Instead of testing import_attach for imported GEM buffers, invoke<br>
drm_gem_is_imported() to do the test.<br>
<br>
Signed-off-by: Thomas Zimmermann <<a href="mailto:tzimmermann@suse.de" target="_blank">tzimmermann@suse.de</a>><br>
---<br>
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c<br>
index 185534f56bab..2bf606ba24cd 100644<br>
--- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c<br>
+++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c<br>
@@ -429,7 +429,7 @@ static void __drm_gem_fb_end_cpu_access(struct drm_framebuffer *fb, enum dma_dat<br>
if (!obj)<br>
continue;<br>
import_attach = obj->import_attach;<br>
- if (!import_attach)<br>
+ if (!drm_gem_is_imported(obj))<br>
continue;<br>
ret = dma_buf_end_cpu_access(import_attach->dmabuf, dir);<br>
if (ret)<br>
@@ -466,7 +466,7 @@ int drm_gem_fb_begin_cpu_access(struct drm_framebuffer *fb, enum dma_data_direct<br>
goto err___drm_gem_fb_end_cpu_access;<br>
}<br>
import_attach = obj->import_attach;<br>
- if (!import_attach)<br>
+ if (!drm_gem_is_imported(obj))<br>
continue;<br>
ret = dma_buf_begin_cpu_access(import_attach->dmabuf, dir);<br>
if (ret)<br>
-- <br>
2.48.1<br>
<br>
</blockquote></div></div>