<div dir="ltr"><div>Thanks for the fix. I shall revisit the rest of my series.</div><div><br></div><div>Reviewed-by: Anusha Srivatsa <<a href="mailto:asrivats@redhat.com">asrivats@redhat.com</a>></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Fri, Feb 28, 2025 at 4:38 AM Dan Carpenter <<a href="mailto:dan.carpenter@linaro.org">dan.carpenter@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The devm_platform_ioremap_resource_byname() function doesn't return NULL,<br>
it returns error pointers.  Update the checking to match.<br>
<br>
Fixes: b93f07cf090a ("drm/vc4: move to devm_platform_ioremap_resource() usage")<br>
Signed-off-by: Dan Carpenter <<a href="mailto:dan.carpenter@linaro.org" target="_blank">dan.carpenter@linaro.org</a>><br>
---<br>
 drivers/gpu/drm/vc4/vc4_hdmi.c | 28 ++++++++++++++--------------<br>
 1 file changed, 14 insertions(+), 14 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c<br>
index d20e5c53ba75..37238a12baa5 100644<br>
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c<br>
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c<br>
@@ -2928,8 +2928,8 @@ static int vc5_hdmi_init_resources(struct drm_device *drm,<br>
<br>
        vc4_hdmi->hdmicore_regs = devm_platform_ioremap_resource_byname(pdev,<br>
                                                                        "hdmi");<br>
-       if (!vc4_hdmi->hdmicore_regs)<br>
-               return -ENOMEM;<br>
+       if (IS_ERR(vc4_hdmi->hdmicore_regs))<br>
+               return PTR_ERR(vc4_hdmi->hdmicore_regs);<br>
<br>
        /* This is shared between both HDMI controllers. Cannot<br>
         * claim for both instances. Lets not convert to using<br>
@@ -2946,33 +2946,33 @@ static int vc5_hdmi_init_resources(struct drm_device *drm,<br>
<br>
        vc4_hdmi->cec_regs = devm_platform_ioremap_resource_byname(pdev,<br>
                                                                   "cec");<br>
-       if (!vc4_hdmi->cec_regs)<br>
-               return -ENOMEM;<br>
+       if (IS_ERR(vc4_hdmi->cec_regs))<br>
+               return PTR_ERR(vc4_hdmi->cec_regs);<br>
<br>
        vc4_hdmi->csc_regs = devm_platform_ioremap_resource_byname(pdev,<br>
                                                                   "csc");<br>
-       if (!vc4_hdmi->csc_regs)<br>
-               return -ENOMEM;<br>
+       if (IS_ERR(vc4_hdmi->csc_regs))<br>
+               return PTR_ERR(vc4_hdmi->csc_regs);<br>
<br>
        vc4_hdmi->dvp_regs = devm_platform_ioremap_resource_byname(pdev,<br>
                                                                   "dvp");<br>
-       if (!vc4_hdmi->dvp_regs)<br>
-               return -ENOMEM;<br>
+       if (IS_ERR(vc4_hdmi->dvp_regs))<br>
+               return PTR_ERR(vc4_hdmi->dvp_regs);<br>
<br>
        vc4_hdmi->phy_regs = devm_platform_ioremap_resource_byname(pdev,<br>
                                                                   "phy");<br>
<br>
-       if (!vc4_hdmi->phy_regs)<br>
-               return -ENOMEM;<br>
+       if (IS_ERR(vc4_hdmi->phy_regs))<br>
+               return PTR_ERR(vc4_hdmi->phy_regs);<br>
<br>
        vc4_hdmi->ram_regs = devm_platform_ioremap_resource_byname(pdev,<br>
                                                                   "packet");<br>
-       if (!vc4_hdmi->ram_regs)<br>
-               return -ENOMEM;<br>
+       if (IS_ERR(vc4_hdmi->ram_regs))<br>
+               return PTR_ERR(vc4_hdmi->ram_regs);<br>
<br>
        vc4_hdmi->rm_regs = devm_platform_ioremap_resource_byname(pdev, "rm");<br>
-       if (!vc4_hdmi->rm_regs)<br>
-               return -ENOMEM;<br>
+       if (IS_ERR(vc4_hdmi->rm_regs))<br>
+               return PTR_ERR(vc4_hdmi->rm_regs);<br>
<br>
        vc4_hdmi->hsm_clock = devm_clk_get(dev, "hdmi");<br>
        if (IS_ERR(vc4_hdmi->hsm_clock)) {<br>
-- <br>
2.47.2<br>
<br>
</blockquote></div></div>