<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Mon, Mar 17, 2025 at 6:12 AM Neil Armstrong <<a href="mailto:neil.armstrong@linaro.org">neil.armstrong@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 13/03/2025 01:54, Anusha Srivatsa wrote:<br>
> Start using the new helper that does the refcounted<br>
> allocations.<br>
> <br>
> Signed-off-by: Anusha Srivatsa <<a href="mailto:asrivats@redhat.com" target="_blank">asrivats@redhat.com</a>><br>
> ---<br>
>   drivers/gpu/drm/panel/panel-simple.c | 4 +---<br>
>   1 file changed, 1 insertion(+), 3 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c<br>
> index 232b03c1a259eb15e423b9d452d28e2ff95c70f8..d7530c3533af34f83ce8c6d6067e7f293f2d4bf1 100644<br>
> --- a/drivers/gpu/drm/panel/panel-simple.c<br>
> +++ b/drivers/gpu/drm/panel/panel-simple.c<br>
> @@ -579,7 +579,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)<br>
>       u32 bus_flags;<br>
>       int err;<br>
>   <br>
> -     panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);<br>
> +     panel = devm_drm_panel_alloc(dev, struct panel_simple, base, &panel_simple_funcs);<br>
>       if (!panel)<br>
>               return -ENOMEM;<br>
>   <br>
> @@ -694,8 +694,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)<br>
>       pm_runtime_set_autosuspend_delay(dev, 1000);<br>
>       pm_runtime_use_autosuspend(dev);<br>
>   <br>
> -     drm_panel_init(&panel->base, dev, &panel_simple_funcs, connector_type);<br>
<br>
As pointed by the helpers review, you're loosing the connector_type info here.<br>
<br></blockquote><div>Yes Niels, Looking into this. The conector type has to be passed from here to the API... </div><div><br></div><div>Anusha </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> -<br>
>       err = drm_panel_of_backlight(&panel->base);<br>
>       if (err) {<br>
>               dev_err_probe(dev, err, "Could not find backlight\n");<br>
> <br>
<br>
Thanks !<br>
Neil<br>
<br>
</blockquote></div></div>