<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Apr 2, 2025 at 5:09 PM Ondřej Jirman <<a href="mailto:megi@xff.cz">megi@xff.cz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Anusha,<br>
<br>
On Wed, Apr 02, 2025 at 11:23:45AM -0400, Anusha Srivatsa wrote:<br>
> Move to using the new API devm_drm_panel_alloc() to allocate the<br>
> panel.<br>
> <br>
> Signed-off-by: Anusha Srivatsa <<a href="mailto:asrivats@redhat.com" target="_blank">asrivats@redhat.com</a>><br>
> ---<br>
>  drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 8 +++++---<br>
>  1 file changed, 5 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c<br>
> index ff39f5dd4097e8da0a0e16c50c5bfd45c078d91c..d87b7eefe9beedd290fb59065b389b3315c85720 100644<br>
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c<br>
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c<br>
> @@ -490,9 +490,11 @@ static int ili9341_dpi_probe(struct spi_device *spi, struct gpio_desc *dc,<br>
>       struct ili9341 *ili;<br>
>       int ret;<br>
>  <br>
> -     ili = devm_kzalloc(dev, sizeof(struct ili9341), GFP_KERNEL);<br>
> -     if (!ili)<br>
> -             return -ENOMEM;<br>
> +     ili = devm_drm_panel_alloc(dev, struct ili9341, panel,<br>
> +                                &ili9341_dpi_funcs,<br>
> +                                DRM_MODE_CONNECTOR_DPI);<br>
> +     if (IS_ERR(ili))<br>
> +             return PTR_ERR(ili);<br>
>  <br>
>       ili->dbi = devm_kzalloc(dev, sizeof(struct mipi_dbi),<br>
>                               GFP_KERNEL);<br>
<br>
Unlike in other patches, in this one you did not remove:<br>
<br>
<a href="https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/panel/panel-ilitek-ili9341.c#L529" rel="noreferrer" target="_blank">https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/panel/panel-ilitek-ili9341.c#L529</a><br>
<br>
        drm_panel_init(&ili->panel, dev, &ili9341_dpi_funcs,<br>
                       DRM_MODE_CONNECTOR_DPI);<br>
<br>
Unintentional?<br>
<br></blockquote><div>Yup. Unintentional. WIll remove this in the next iteration.</div><div><br></div><div>Thanks!</div><div>Anusha <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
kind regards,<br>
        o.<br>
<br>
> -- <br>
> 2.48.1<br>
> <br>
<br>
</blockquote></div></div>