<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli <<a href="mailto:luca.ceresoli@bootlin.com">luca.ceresoli@bootlin.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This is the new API for allocating DRM bridges.<br>
<br>
Signed-off-by: Luca Ceresoli <<a href="mailto:luca.ceresoli@bootlin.com" target="_blank">luca.ceresoli@bootlin.com</a>><br>
<br>
---<br>
<br>
Cc: Ian Ray <<a href="mailto:ian.ray@gehealthcare.com" target="_blank">ian.ray@gehealthcare.com</a>><br>
Cc: Martyn Welch <<a href="mailto:martyn.welch@collabora.co.uk" target="_blank">martyn.welch@collabora.co.uk</a>><br>
Cc: Peter Senna Tschudin <<a href="mailto:peter.senna@gmail.com" target="_blank">peter.senna@gmail.com</a>><br>
<br>
Changed in v3:<br>
- updated Ian Ray's e-mail (old one is bouncing</blockquote><div> ^^^^^^ you missed closing the breaces here.</div><div> </div><div>Code changes look good.</div><div><br></div><div>Reviewed-by: Anusha Srivatsa <<a href="mailto:asrivats@redhat.com">asrivats@redhat.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Changed in v2: none<br>
---<br>
drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 11 ++++-------<br>
1 file changed, 4 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c<br>
index 15a5a1f644fc10182c55bc9e489ccb81d4f924f9..81dde9ed7bcf7cacae000d9da31a3a5c347ce037 100644<br>
--- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c<br>
+++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c<br>
@@ -225,13 +225,11 @@ static int ge_b850v3_lvds_init(struct device *dev)<br>
if (ge_b850v3_lvds_ptr)<br>
goto success;<br>
<br>
- ge_b850v3_lvds_ptr = devm_kzalloc(dev,<br>
- sizeof(*ge_b850v3_lvds_ptr),<br>
- GFP_KERNEL);<br>
-<br>
- if (!ge_b850v3_lvds_ptr) {<br>
+ ge_b850v3_lvds_ptr = devm_drm_bridge_alloc(dev, struct ge_b850v3_lvds, bridge,<br>
+ &ge_b850v3_lvds_funcs);<br>
+ if (IS_ERR(ge_b850v3_lvds_ptr)) {<br>
mutex_unlock(&ge_b850v3_lvds_dev_mutex);<br>
- return -ENOMEM;<br>
+ return PTR_ERR(ge_b850v3_lvds_ptr);<br>
}<br>
<br>
success:<br>
@@ -264,7 +262,6 @@ static int ge_b850v3_register(void)<br>
struct device *dev = &stdp4028_i2c->dev;<br>
<br>
/* drm bridge initialization */<br>
- ge_b850v3_lvds_ptr->bridge.funcs = &ge_b850v3_lvds_funcs;<br>
ge_b850v3_lvds_ptr->bridge.ops = DRM_BRIDGE_OP_DETECT |<br>
DRM_BRIDGE_OP_EDID;<br>
ge_b850v3_lvds_ptr->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;<br>
<br>
-- <br>
2.49.0<br>
<br></blockquote><div>thanks,</div><div>Anusha </div></div></div>