<html><body><p>
<pre>
On Mon, 2025-06-02 at 01:31 +0800, Jason-JH Lin wrote:
> The GCE hardware virtualization configuration supports the isolation of
> GCE hardware resources across different OS environments. Each OS is
> treated as a virtual machine (VM) for GCE purposes.
> There are 6 VMs and 1 host VM. The host VM has main control over the
> GCE virtualization settings for all VMs.
>
> To properly access the GCE thread registers, it is necessary to
> configure access permissions for specific GCE threads assigned to
> different VMs.
> Currently, since only the host VM is being used, it is required to
> enable access permissions for all GCE threads for the host VM.
>
> There are 2 VM configurations:
> 1. VM_ID_MAP
> There are 4 registers to allocate 32 GCE threads across different VMs:
> VM_ID_MAP0 for threads 0-9, VM_ID_MAP1 for threads 10-19,
> VM_ID_MAP2 for threads 20-29, and VM_ID_MAP3 for threads 30-31.
> Each thread has a 3-bit configuration, where setting all bits to 1
> configures the thread for the host VM.
>
> 2. VM_CPR_GSIZE
> It is used to allocate the CPR SRAM size to each VM. Each VM has 4-bit
> configuration, where setting bit 0-3 to configures the size of host VM.
> This setting must be configured before the VM configuration to prevent
> resource leakage.
>
> Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com>
> ---
[snip]
> +
> static void cmdq_gctl_value_toggle(struct cmdq *cmdq, bool ddr_enable)
> {
> u32 val = cmdq->pdata->control_by_sw ? GCE_CTRL_BY_SW : 0;
> @@ -162,6 +211,7 @@ static void cmdq_init(struct cmdq *cmdq)
>
> WARN_ON(clk_bulk_enable(cmdq->pdata->gce_num, cmdq->clocks));
>
> +cmdq_vm_toggle(cmdq, true);
> cmdq_gctl_value_toggle(cmdq, true);
>
> writel(CMDQ_THR_ACTIVE_SLOT_CYCLES, cmdq->base + CMDQ_THR_SLOT_CYCLES);
> @@ -335,6 +385,7 @@ static int cmdq_runtime_resume(struct device *dev)
> if (ret)
> return ret;
>
> +cmdq_vm_toggle(cmdq, true);
> cmdq_gctl_value_toggle(cmdq, true);
> return 0;
> }
> @@ -344,6 +395,7 @@ static int cmdq_runtime_suspend(struct device *dev)
> struct cmdq *cmdq = dev_get_drvdata(dev);
>
> cmdq_gctl_value_toggle(cmdq, false);
> +cmdq_vm_toggle(cmdq, false);
Why turn off permission when suspend?
Why not always turn on permission?
Regards,
CK
> clk_bulk_disable(cmdq->pdata->gce_num, cmdq->clocks);
> return 0;
> }
</pre>
</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice
********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!
</pre><!--}-->