[Mesa-dev] [PATCH 1/4] gallium: add pipe_screen::resource_changed

Philipp Zabel p.zabel at pengutronix.de
Mon Dec 5 10:43:44 UTC 2016


Am Montag, den 05.12.2016, 11:19 +0100 schrieb Philipp Zabel:
> Hi Marek,
> 
> Am Freitag, den 02.12.2016, 23:10 +0100 schrieb Marek Olšák:
> > Shouldn't this be in pipe_context if it does a copy?

Actually, resource_changed is not supposed to create a copy immediately.
Maybe instead of "trigger recreation of derived internal resources" it
should be described as "mark resource as changed so derived internal
resources will be recreated on next use".

> > It's basically the opposite of flush_resource, right?

Contrary to flush_resource, which has an immediate, externally visible
effect for which a context may be needed, resource_changed can just
update some internal state. The changed resource should be marked as
changed for all contexts, which is why I saw no reason to call
resource_changed with any one specific context.

regards
Philipp



More information about the etnaviv mailing list