[PATCH 5/7] etnaviv: apply non-alpha workaround to temporary copy in acquire_src

Russell King rmk at armlinux.org.uk
Tue Nov 22 16:04:17 UTC 2016


On Tue, Nov 22, 2016 at 12:44:18PM +0100, Lucas Stach wrote:
> The blit into the temporary pixmap needs the same workaround for
> non-alpha formats as all other blits.

Okay, I'm including details of this failure when committing it, but it
needs to be the first patch in these fixes, because it's the first
failure rendercheck finds - it masks the other rendercheck failures.

However, I'd like you to also explain:

> +	/*
> +	 * Reset pixmap format to original one, as the calling function may depend
> +	 * on this to be unchanged.
> +	 */
> +	etnaviv_set_format(vSrc, pict);
> +

If that's really true, we should be saving and restoring it, not
resetting it back to whatever the picture says it should be.  However,
I don't think this is necessary - we're not going to be using the
source in this path again.

-- 
Russell King


More information about the etnaviv mailing list