[PATCH 1/2] etnaviv: fix etna_bo_from_name

Wladimir J. van der Laan laanwj at gmail.com
Sat Aug 5 06:40:42 UTC 2017


On Fri, Aug 04, 2017 at 06:54:12PM +0200, Philipp Zabel wrote:
> On Fri, 2017-08-04 at 18:15 +0200, Wladimir J. van der Laan wrote:
> > On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote:
> > > Look up BOs from the name table using the name parameter instead of
> > > req.handle (which at this point is always zero).
> > 
> > Good catch.
> > 
> > Just out of interest: when is this used, what problems does this cause?
> 
> It is used by the etnaviv gallium driver in etna_screen_bo_from_handle
> for DRM_API_HANDLE_TYPE_SHARED handles. Since this just falls back to
> asking the kernel to DRM_IOCTL_GEM_OPEN if the BO is not found in the
> name_table already, this bug caused no problems.

Thanks for the explanation,

Reviewed-By: Wladimir J. van der Laan

Regards,
Wladimir


More information about the etnaviv mailing list