[PATCH 2/3] drm/etnaviv: move fence allocation out of etnaviv_gpu_submit()

Gustavo Padovan gustavo at padovan.org
Wed Mar 8 14:42:17 UTC 2017


Hi Philipp,

2017-03-08 Philipp Zabel <p.zabel at pengutronix.de>:

> The next patch will need the dma_fence to create the sync_file in
> etnaviv_ioctl_gem_submit, in case an out_fence_fd is requested.
> 
> Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gem.h        |  3 ++-
>  drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c |  8 +++++++-
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c        | 21 ++++++---------------
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.h        |  1 +
>  4 files changed, 16 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.h b/drivers/gpu/drm/etnaviv/etnaviv_gem.h
> index 120410d67eb5b..c4a091e874269 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.h
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.h
> @@ -20,6 +20,7 @@
>  #include <linux/reservation.h>
>  #include "etnaviv_drv.h"
>  
> +struct dma_fence;

Why not #include <linux/dma_fence.h> ?

Other than that looks good to me:

Reviewed-by: Gustavo Padovan <gustavo.padovan at collabora.com>

Gustavo


More information about the etnaviv mailing list