[PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

Lucas Stach l.stach at pengutronix.de
Wed Nov 1 13:27:40 UTC 2017


Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan:
> On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote:
> > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer) 
> > here, which seems more consistent with the rest of the codebase.
> 
> Well, I mimiced the style from other assertion in the function which compares
> explicitly with NULL. But ok, I'll update it some time.

If you agree with my suggestion I can also just fix it up while
applying, but I'll leave the decision how you want to handle this up to
you.

Regards,
Lucas


More information about the etnaviv mailing list