[PATCH] [FYI] etnaviv: use ktime_t for timeouts

Russell King - ARM Linux linux at armlinux.org.uk
Mon Nov 6 15:07:04 UTC 2017


On Mon, Nov 06, 2017 at 03:44:40PM +0100, Arnd Bergmann wrote:
> This is what I ended up with after Lucas' email this morning,
> it should result in exactly the same behavior as Russell's patch
> but also remove all traces of 'timespec' from the kernel.

What if userspace passes in a zero timeout?  Your patch appears to
make that non-blocking.  I'd rather keep the semantics different
as they are today, and pass the drm_etnaviv_timeout into the
functions rather than a ktime.

Remember that the specs for the monotonic clock_gettime() allow
systems to define an arbitary starting value.  That starting value
could be a negative number, which would mean a timestamp of all
zeros is a legal timestamp in the future.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up


More information about the etnaviv mailing list