Question regarding HDMI Audio support on i.MX6 with vanilla kernel

[Luís Mendes]

Hi,

Replies in between...

Regards,
Luís

On Tue, Nov 7, 2017 at 10:30 AM, Russell King - ARM Linux <
linux at armlinux.org.uk> wrote:

> On Tue, Nov 07, 2017 at 10:15:02AM +0000, Russell King - ARM Linux wrote:
> > On Tue, Nov 07, 2017 at 10:00:48AM +0000, Luís Mendes wrote:
> > > an EDID is forced through drm_kms_helper.edid_firmware=
> edid/ktc_edid.bin,
> > > because dw_hdmi_connector_get_modes(...) won't get called, causing
> the
> > > edid not to be parsed for audio suppport, nor for the HDMI connector
> > > support. As a result DVI mode will always be used.
> >
> > Yes, when using an override EDID, audio probably won't work because the
> > parsing calls are mis-placed.  I thought that had been fixed.
>
> Hi,
>
> This should fix this particular issue, which is definitely a bug in the
> driver.  Please test.
>

Yes, the issue is fixed with this patch. I am now able to force the EDID
and the HDMI and Audio sink are properly set. Thanks!

>
> As previously explained, I can't fathom how xf86-video-armada would get
> the EDID of your TV without dw-hdmi first getting the EDID itself,
> except via override or similar to what you're doing above.
>

I will check this better, I will try what you suggested in the following
email to this one.

>
> Thanks.
>
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 28
> ++++++++++++++++++++++++----
>  1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 9fe407f49986..2516a1c18a10 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1918,10 +1918,7 @@ static int dw_hdmi_connector_get_modes(struct
> drm_connector *connector)
>                 dev_dbg(hdmi->dev, "got edid: width[%d] x height[%d]\n",
>                         edid->width_cm, edid->height_cm);
>
> -               hdmi->sink_is_hdmi = drm_detect_hdmi_monitor(edid);
> -               hdmi->sink_has_audio = drm_detect_monitor_audio(edid);
>                 drm_mode_connector_update_edid_property(connector, edid);
> -               cec_notifier_set_phys_addr_from_edid(hdmi->cec_notifier,
> edid);
>                 ret = drm_add_edid_modes(connector, edid);
>                 /* Store the ELD */
>                 drm_edid_to_eld(connector, edid);
> @@ -1933,6 +1930,29 @@ static int dw_hdmi_connector_get_modes(struct
> drm_connector *connector)
>         return ret;
>  }
>
> +static int dw_hdmi_connector_fill_modes(struct drm_connector *connector,
> +                                       uint32_t maxX, uint32_t maxY)
> +{
> +       struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi,
> +                                           connector);
> +       int ret;
> +
> +       ret = drm_helper_probe_single_connector_modes(connector, maxX,
> maxY);
> +
> +       if (connector->edid_blob_ptr) {
> +               struct edid *edid = (void *)connector->edid_blob_ptr->
> data;
> +
> +               hdmi->sink_is_hdmi = drm_detect_hdmi_monitor(edid);
> +               hdmi->sink_has_audio = drm_detect_monitor_audio(edid);
> +               cec_notifier_set_phys_addr_from_edid(hdmi->cec_notifier,
> edid);
> +       } else {
> +               hdmi->sink_is_hdmi = false;
> +               hdmi->sink_has_audio = false;
> +       }
> +
> +       return ret;
> +}
> +
>  static void dw_hdmi_connector_force(struct drm_connector *connector)
>  {
>         struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi,
> @@ -1946,7 +1966,7 @@ static void dw_hdmi_connector_force(struct
> drm_connector *connector)
>  }
>
>  static const struct drm_connector_funcs dw_hdmi_connector_funcs = {
> -       .fill_modes = drm_helper_probe_single_connector_modes,
> +       .fill_modes = dw_hdmi_connector_fill_modes,
>         .detect = dw_hdmi_connector_detect,
>         .destroy = drm_connector_cleanup,
>         .force = dw_hdmi_connector_force,
>
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps
> up
> According to speedtest.net: 8.21Mbps down 510kbps up
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/etnaviv/attachments/20171107/6150b583/attachment-0001.html>