[PATCH] etnaviv: fix texture_format_needs_swiz

[Lucas Stach]

Pushed, thanks all!

Am Freitag, den 20.04.2018, 17:58 +0200 schrieb Christian Gmeiner:
> 2018-04-20 14:37 GMT+02:00 Lucas Stach <l.stach at pengutronix.de>:
> > memcmp returns 0 when both swizzles are the same, which means we
> > don't
> > need any swizzling. texture_format_needs_swiz needs to returns true
> > when the return value of the memcmp is non-zero.
> > 
> 
> Fixes: 751ae6afbefd6e0b3cbf9323995465d5a078c9fb ("etnaviv: add
> support
> for swizzled texture formats")
> Cc: mesa-stable at lists.freedesktop.org
> Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> 
> > Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
> > ---
> >  src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c
> > b/src/gallium/drivers/etnaviv/etnaviv_format.c
> > index 7943c819d511..29e81c4a8b04 100644
> > --- a/src/gallium/drivers/etnaviv/etnaviv_format.c
> > +++ b/src/gallium/drivers/etnaviv/etnaviv_format.c
> > @@ -302,7 +302,7 @@ texture_format_needs_swiz(enum pipe_format fmt)
> >     bool swiz = false;
> > 
> >     if (formats[fmt].present)
> > -      swiz = !memcmp(def, formats[fmt].tex_swiz,
> > sizeof(formats[fmt].tex_swiz));
> > +      swiz = !!memcmp(def, formats[fmt].tex_swiz,
> > sizeof(formats[fmt].tex_swiz));
> > 
> >     return swiz;
> >  }
> > --
> > 2.16.3
> > 
> > _______________________________________________
> > etnaviv mailing list
> > etnaviv at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/etnaviv
> 
> 
>