[xf86-video-armada][PATCH 1/2] Remove 24bbp support

[Stefan Agner]

On 17.08.2018 18:27, Russell King wrote:
> On Fri, Aug 17, 2018 at 06:15:29PM +0200, Christian Gmeiner wrote:
>> Am Fr., 17. Aug. 2018 um 16:05 Uhr schrieb Stefan Agner <stefan at agner.ch>:
>> >
>> > 24bbp support has been removed in X.Org Server 1.20 so
>> > remove it from this driver as well.
>>
>> Would it not be better to conditionally remove 24bbp support based on
>> FB_24_32BIT existence? If this driver
>> gets build against an older version of xserver api we would regress
>> regarding 24bbp support. But keep in mind
>> this are just my 2 cent :) I am not even sure if 24bbp gets used in the wild.
> 
> 32bpp with a 24 bit depth is the common case - 24bpp is less so. The
> Dove LCDC supports 24bpp (3 bytes per pixel) packed format, so there
> is hardware around that does support it, but I don't think it would
> be as efficient as 32bpp.  Etnaviv doesn't support it, so it would be
> difficult to use with GPU acceleration.
> 
> However, I'd be inclined to go with Christian's suggestion wrt avoiding
> an unnecessary regression for older Xservers - it's not like it's
> expensive to keep that code around.

Sounds reasonable, will send a v2.

--
Stefan