[Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

Daniel Stone daniel at fooishbar.org
Wed Jan 31 11:37:19 UTC 2018


On 30 January 2018 at 14:22, Lucas Stach <l.stach at pengutronix.de> wrote:
> Take into account the resource format, instead of applying a hardcoded
> 32bpp. This not only over-allocates 16bpp formats, but also results in
> a wrong stride being filled into the handle.

Bikeshed: just use util_format_getblocksizebits()? getblocksize()
internally just divides getblocksizebits by 8, so this is redundant.
WIth that:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the etnaviv mailing list