[PATCH 1/3] drm/etnaviv: skip command stream validation on PPAS capable GPUs

[Philipp Zabel]

On Fri, 2019-08-02 at 19:29 +0200, Lucas Stach wrote:
> With per-process address spaces in place, a rogue process submitting
> bogus command streams can only hurt itself. There is no need to
> validate the command stream before execution anymore.
> 
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> index 27a14a270a55..627c80ed63d8 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> @@ -517,7 +517,8 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
>  	if (ret)
>  		goto err_submit_objects;
>  
> -	if (!etnaviv_cmd_validate_one(gpu, stream, args->stream_size / 4,
> +	if ((priv->mmu_global->version != ETNAVIV_IOMMU_V2) &&
> +	    !etnaviv_cmd_validate_one(gpu, stream, args->stream_size / 4,
>  				      relocs, args->nr_relocs)) {
>  		ret = -EINVAL;
>  		goto err_submit_objects;


Reviewed-by: Philipp Zabel <p.zabel at pengutronix.de>

regards
Philipp