[PATCH] drm/etnaviv: dump only failing submit

[Philipp Zabel]

On Tue, 2019-07-02 at 16:18 +0200, Lucas Stach wrote:
> Due to the tracking provided by the scheduler we know exactly which
> submit is failing. Only dump this single submit and the required
> auxiliary information. This cuts down the size of the devcoredumps
> by only including relevant information.
> 
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_dump.c  | 57 +++++++++----------------
>  drivers/gpu/drm/etnaviv/etnaviv_dump.h  |  4 +-
>  drivers/gpu/drm/etnaviv/etnaviv_sched.c |  2 +-
>  3 files changed, 22 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
> index 515515ef24f9..bab09bae35d0 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
> @@ -91,9 +91,9 @@ static void etnaviv_core_dump_registers(struct core_dump_iterator *iter,
>  }
>  
>  static void etnaviv_core_dump_mmu(struct core_dump_iterator *iter,
> -	struct etnaviv_gpu *gpu, size_t mmu_size)
> +	struct etnaviv_iommu *mmu, size_t mmu_size)
>  {
> -	etnaviv_iommu_dump(gpu->mmu, iter->data);
> +	etnaviv_iommu_dump(mmu, iter->data);
>  
>  	etnaviv_core_dump_header(iter, ETDUMP_BUF_MMU, iter->data + mmu_size);
>  }
[...]
> @@ -181,19 +167,15 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu)
>  	memset(iter.hdr, 0, iter.data - iter.start);
>  
>  	etnaviv_core_dump_registers(&iter, gpu);
> -	etnaviv_core_dump_mmu(&iter, gpu, mmu_size);
> +	etnaviv_core_dump_mmu(&iter, gpu->mmu, mmu_size);
> +

I'd split this into a separate commit, or at least mention it in the
commit message. This change is neither necessary for nor enabled by the
rest of the patch. Otherwise,

Reviewed-by: Philipp Zabel <p.zabel at pengutronix.de>

regards
Philipp