[PATCH] drm/etnaviv: don't restrict to certain architectures

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Jan 21 16:55:09 UTC 2019


On Wed, Jan 16, 2019 at 04:27:58PM +0100, Lucas Stach wrote:
> The Vivante GPU cores are found in many different SoCs and the driver
> does not depend on anything architecture specific, so just drop the
> architecture restriction.

With my Debian kernel team member hat on I don't like changes like this.
I don't know in which machines the etnaviv IP is available. Should the
Debian kernel enable it on x86? powerpc? riscv? If MXC + DOVE isn't
enough, it's your opportunity to not waste time of people who don't know
etnaviv by heart and only expand the dependency carefully.

Having said that I see the benefit of being able to enable the driver on
a wide variety of machines. It's flexible and everyone who doesn't want
that driver can still just disable it.

But when making this change, please consider also all the people who
will see

	ETNAVIV (DRM support for Vivante GPU IP cores) (DRM_ETNAVIV) [N/y/m/?] (NEW)

in their next run of make oldconfig and need to decide if this driver is
useful for them. Also note they only see

	DRM driver for Vivante GPUs.

when pressing '?'.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |


More information about the etnaviv mailing list