[BUG] etnaviv: broken timeouts

[Kyle Russell]

Oh, great! Thanks! I missed that.

On Fri, Mar 15, 2019, 5:14 AM Lucas Stach <l.stach at pengutronix.de> wrote:

> Hi Kyle,
>
> Am Donnerstag, den 14.03.2019, 23:29 -0400 schrieb Kyle Russell:
> > I've observed the timeouts issue originally reported in this thread on a
> > 4.17 aarch64 kernel, and it has reproduced reliably every boot.  I tried
> > the "normal" timespec patch that Russell provided, and that seems to
> > have fixed it up.  Before finding this thread, I similarly considered
> > using ktime_get_ts instead of timespec_to_jiffies while debugging the
> > issue.  There don't appear to be many clients of timespec_to_jiffies, at
> > least in 4.17.
> >
> > Is this patch acceptable for now, or is it worth holding off for a more
> > fundamental fix?
> >
> > I haven't inspected the other usages of timespec_to_jiffies in detail,
> > or searched newer kernel versions to see if usage of timespec_to_jiffies
> > has changed, but if ktime_get_ts addresses some subtleties, maybe it's
> > worth removing timespec_to_jiffies?
> >
> > I'll be glad to help however I can.
>
> This fix has been merged as d066b246d482 (drm/etnaviv: correct timeout
> calculation) into kernel 4.18. It hasn't been tagged for stable, but
> 4.17 is EOL anyways, so I suggest to consider moving to a newer kernel
> release.
>
> Regards,
> Lucas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/etnaviv/attachments/20190315/daaad92e/attachment.html>