[PATCH] etnaviv: only try to construct scanout resource when on KMS winsys

Christian Gmeiner christian.gmeiner at gmail.com
Wed Mar 27 14:03:52 UTC 2019


Am Mi., 27. März 2019 um 12:25 Uhr schrieb Lucas Stach <l.stach at pengutronix.de>:
>
> Trying to construct a scanout capable buffer will only ever work when
> when we are on top of a KMS winsys, as the render node isn't capable
> of allocating contiguous buffers.
>
> Tested-by: Marius Vlad <marius.vlad at collabora.com>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>

> ---
>  src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c b/src/gallium/drivers/etnaviv/etnaviv_resource.c
> index c7eedab74187..83179d3cd088 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_resource.c
> +++ b/src/gallium/drivers/etnaviv/etnaviv_resource.c
> @@ -238,7 +238,7 @@ etna_resource_alloc(struct pipe_screen *pscreen, unsigned layout,
>     if (!screen->specs.use_blt && templat->target != PIPE_BUFFER)
>        etna_adjust_rs_align(screen->specs.pixel_pipes, NULL, &paddingY);
>
> -   if (templat->bind & PIPE_BIND_SCANOUT) {
> +   if (templat->bind & PIPE_BIND_SCANOUT && screen->ro->kms_fd >= 0) {
>        struct pipe_resource scanout_templat = *templat;
>        struct renderonly_scanout *scanout;
>        struct winsys_handle handle;
> --
> 2.20.1
>
> _______________________________________________
> etnaviv mailing list
> etnaviv at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/etnaviv



-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info


More information about the etnaviv mailing list