[PATCH v2] drm/etnaviv: Remove redundant dev_err()
Kang Minchul
tegongkang at gmail.com
Mon Dec 12 19:26:02 UTC 2022
2022년 12월 12일 (월) 오후 3:14, Kang Minchul <tegongkang at gmail.com>님이 작성:
>
> Function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Signed-off-by: Kang Minchul <tegongkang at gmail.com>
> ---
> Changes in v2:
> - Removed unnecessary braces.
>
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index a31eeff2b297..6dbe0c45b695 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1770,10 +1770,8 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
>
> /* Get Interrupt: */
> gpu->irq = platform_get_irq(pdev, 0);
> - if (gpu->irq < 0) {
> - dev_err(dev, "failed to get irq: %d\n", gpu->irq);
> + if (gpu->irq < 0)
> return gpu->irq;
> - }
>
> err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> dev_name(gpu->dev), gpu);
> --
> 2.34.1
>
I guess problem dealt with by this patch have already been resolved in the past.
I think I worked on the wrong branch.
Please ignore this patch.
Sorry for your inconvenience.
Regards,
Kang Minchul
More information about the etnaviv
mailing list