[PATCH v2] drm/etnaviv: avoid cleaning up sched_job when submit succeeded

Michael Walle michael at walle.cc
Wed May 4 20:58:57 UTC 2022


Am 2022-05-04 11:02, schrieb Lucas Stach:
> While the labels may mislead the casual reader, the tail of the 
> function
> etnaviv_ioctl_gem_submit is always executed, as a lot of the structures
> set up in this function need to be cleaned up regardless of whether the
> submit succeeded or failed.
> 
> An exception is the newly added drm_sched_job_cleanup, which must only
> be called when the submit failed before handing the job to the
> scheduler.
> 
> Fixes: b827c84f5e84 ("drm/etnaviv: Use scheduler dependency handling")
> Reported-by: Michael Walle <michael at walle.cc>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

FWIW (because it's already picked up)

Tested-by: Michael Walle <michael at walle.cc>

Thanks!
-michael


More information about the etnaviv mailing list