[PATCH 3/3] drm/etnaviv: Print an error message if inserting IOVA range fails
Lucas Stach
l.stach at pengutronix.de
Mon Oct 7 10:20:18 UTC 2024
Am Samstag, dem 05.10.2024 um 03:42 +0800 schrieb Sui Jingfeng:
> Print an error message to help debug when such an issue happen, since it's
> not so obvious.
>
> Signed-off-by: Sui Jingfeng <sui.jingfeng at linux.dev>
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
> ---
> v0 -> v1: Use dev_err_ratelimited() to prevent spamming the logs
>
> v0 is at https://lore.kernel.org/dri-devel/20240930221706.399139-1-sui.jingfeng@linux.dev/
> ---
> drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index a52ec5eb0e3d..37866ed05c13 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -300,8 +300,12 @@ int etnaviv_iommu_map_gem(struct etnaviv_iommu_context *context,
> ret = etnaviv_iommu_insert_exact(context, node, user_size, va);
> else
> ret = etnaviv_iommu_find_iova(context, node, user_size);
> - if (ret < 0)
> + if (ret < 0) {
> + dev_err_ratelimited(context->global->dev,
> + "Insert iova failed: 0x%llx(0x%x)\n",
> + va, user_size);
> goto unlock;
> + }
>
> mapping->iova = node->start;
> ret = etnaviv_iommu_map(context, node->start, user_size, sgt,
More information about the etnaviv
mailing list