[farsight2/master] Remove the now redundant (with notify) FsStream::recv-codecs-changed signal
Olivier Crête
olivier.crete at collabora.co.uk
Tue Dec 23 15:21:55 PST 2008
---
gst-libs/gst/farsight/fs-stream.c | 28 ++++------------------------
gst/fsrtpconference/fs-rtp-stream.c | 1 -
2 files changed, 4 insertions(+), 25 deletions(-)
diff --git a/gst-libs/gst/farsight/fs-stream.c b/gst-libs/gst/farsight/fs-stream.c
index 89fb517..150cc05 100644
--- a/gst-libs/gst/farsight/fs-stream.c
+++ b/gst-libs/gst/farsight/fs-stream.c
@@ -151,7 +151,10 @@ fs_stream_class_init (FsStreamClass *klass)
* This is the list of codecs that have been received by this stream.
* The user must free the list if fs_codec_list_destroy().
* The #GObject::notify signal is emitted when the value of this property may
- * have changed.
+ * have changed. It is normally emitted right after #FsStream::src-pad-added
+ * only if that codec was not previously received in this stream, but it can
+ * also be emitted if the pad already exists, but the source material that
+ * will come to it is different.
*
*/
g_object_class_install_property (gobject_class,
@@ -268,29 +271,6 @@ fs_stream_class_init (FsStreamClass *klass)
G_TYPE_NONE, 2, GST_TYPE_PAD, FS_TYPE_CODEC);
/**
- * FsStream::recv-codecs-changed:
- * @self: #FsStream that emitted the signal
- *
- * This signal is emitted when the list of currently received codecs has
- * changed. They can be fetched from the #FsStream:current-recv-codecs
- * property.
- * This is useful for displaying the current active reception codecs.
- * This signal is normally emitted right after src-pad-added only if that
- * codec was not previously received in this stream, but it can also be
- * emitted if the pad already exists, but the source material that will
- * come to it is different.
- *
- */
- signals[RECV_CODECS_CHANGED] = g_signal_new ("recv-codecs-changed",
- G_TYPE_FROM_CLASS (klass),
- G_SIGNAL_RUN_LAST,
- 0,
- NULL,
- NULL,
- g_cclosure_marshal_VOID__VOID,
- G_TYPE_NONE, 0);
-
- /**
* FsStream::new-active-candidate-pair:
* @self: #FsStream that emitted the signal
* @local_candidate: #FsCandidate of the local candidate being used
diff --git a/gst/fsrtpconference/fs-rtp-stream.c b/gst/fsrtpconference/fs-rtp-stream.c
index d0618de..5f7628e 100644
--- a/gst/fsrtpconference/fs-rtp-stream.c
+++ b/gst/fsrtpconference/fs-rtp-stream.c
@@ -739,7 +739,6 @@ _idle_emit_recv_codecs_changed (gpointer data)
FsRtpStream *stream = FS_RTP_STREAM (data);
g_object_notify (G_OBJECT (stream), "current-recv-codecs");
- g_signal_emit_by_name (stream, "recv-codecs-changed");
FS_RTP_SESSION_LOCK (stream->priv->session);
stream->priv->recv_codecs_changed_idle_id = 0;
--
1.5.6.5
More information about the farsight-commits
mailing list