[farsight2/master] Remove now unused/obsolete new-negotiated-codecs signal

Olivier Crête olivier.crete at collabora.co.uk
Tue Dec 23 15:21:57 PST 2008


---
 gst-libs/gst/farsight/fs-session.c   |   31 +++++--------------------------
 gst/fsrtpconference/fs-rtp-session.c |    3 ---
 2 files changed, 5 insertions(+), 29 deletions(-)

diff --git a/gst-libs/gst/farsight/fs-session.c b/gst-libs/gst/farsight/fs-session.c
index a23eb35..8287b40 100644
--- a/gst-libs/gst/farsight/fs-session.c
+++ b/gst-libs/gst/farsight/fs-session.c
@@ -57,7 +57,6 @@
 enum
 {
   ERROR,
-  NEW_NEGOTIATED_CODECS,
   LAST_SIGNAL
 };
 
@@ -202,8 +201,11 @@ fs_session_class_init (FsSessionClass *klass)
    * session participants. This list can change based on participants
    * joining/leaving the session. It is a #GList of #FsCodec. User must free
    * this codec list using fs_codec_list_destroy() when done.
-   * The #FsSession::new-negotiated-codecs signal is emited when the content
-   * of this property changes.
+   *
+   * The #GObject::notify signal is emited when the content of this property
+   * changes. This can happen when new remote codecs are added to the session
+   * (i.e. When a session is being initialized or a new participant joins an
+   * existing session).
    *
    */
   g_object_class_install_property (gobject_class,
@@ -254,29 +256,6 @@ fs_session_class_init (FsSessionClass *klass)
       NULL,
       _fs_marshal_VOID__OBJECT_INT_STRING_STRING,
       G_TYPE_NONE, 4, G_TYPE_OBJECT, G_TYPE_INT, G_TYPE_STRING, G_TYPE_STRING);
-
-  /**
-   * FsSession::new-negotiated-codecs:
-   * @self: #FsSession that emitted the signal
-   *
-   * This signal is emitted when the negotiated codecs list has changed for this
-   * session. This can happen when new remote codecs are added to the session
-   * (i.e. When a session is being initialized or a new participant joins an
-   * existing session). The user should look at the
-   * #FsSession:negotiated-codecs property to determine what the new
-   * negotiated codec list is.
-   *
-   */
-  signals[NEW_NEGOTIATED_CODECS] = g_signal_new ("new-negotiated-codecs",
-      G_TYPE_FROM_CLASS (klass),
-      G_SIGNAL_RUN_LAST,
-      0,
-      NULL,
-      NULL,
-      g_cclosure_marshal_VOID__VOID,
-      G_TYPE_NONE, 0);
-
-  // g_type_class_add_private (klass, sizeof (FsSessionPrivate));
 }
 
 static void
diff --git a/gst/fsrtpconference/fs-rtp-session.c b/gst/fsrtpconference/fs-rtp-session.c
index cb8c9d1..e908a6b 100644
--- a/gst/fsrtpconference/fs-rtp-session.c
+++ b/gst/fsrtpconference/fs-rtp-session.c
@@ -1680,10 +1680,7 @@ fs_rtp_session_negotiate_codecs (FsRtpSession *session,
     FS_RTP_SESSION_UNLOCK (session);
 
     if (is_new)
-    {
-      g_signal_emit_by_name (session, "new-negotiated-codecs");
       g_object_notify (G_OBJECT (session), "negotiated-codecs");
-    }
 
     return TRUE;
   } else {
-- 
1.5.6.5




More information about the farsight-commits mailing list