[farsight2/master] Give substream/session elements meaningful names

Olivier Crête olivier.crete at collabora.co.uk
Tue Dec 23 15:24:09 PST 2008


---
 gst/fsrtpconference/fs-rtp-session.c   |    2 +-
 gst/fsrtpconference/fs-rtp-substream.c |   11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/gst/fsrtpconference/fs-rtp-session.c b/gst/fsrtpconference/fs-rtp-session.c
index 41c4ae0..d41cc8d 100644
--- a/gst/fsrtpconference/fs-rtp-session.c
+++ b/gst/fsrtpconference/fs-rtp-session.c
@@ -2629,7 +2629,7 @@ fs_rtp_session_substream_set_codec_bin (FsRtpSession *session,
     goto out;
   }
 
-  name = g_strdup_printf ("recv%u_%d", ssrc, pt);
+  name = g_strdup_printf ("recv_%d_%u_%d", session->id, ssrc, pt);
   codecbin = _create_codec_bin (bp, new_codec, name, FALSE, error);
   g_free (name);
 
diff --git a/gst/fsrtpconference/fs-rtp-substream.c b/gst/fsrtpconference/fs-rtp-substream.c
index c3132a1..aaa0fde 100644
--- a/gst/fsrtpconference/fs-rtp-substream.c
+++ b/gst/fsrtpconference/fs-rtp-substream.c
@@ -484,6 +484,7 @@ fs_rtp_sub_stream_constructed (GObject *object)
   FsRtpSubStream *self = FS_RTP_SUB_STREAM (object);
   GstPad *capsfilter_sink_pad = NULL;
   GstPadLinkReturn linkret;
+  gchar *tmp;
 
   GST_DEBUG ("New substream in session %u for ssrc %x and pt %u",
       self->priv->session->id, self->priv->ssrc, self->priv->pt);
@@ -494,7 +495,10 @@ fs_rtp_sub_stream_constructed (GObject *object)
     return;
   }
 
-  self->priv->valve = gst_element_factory_make ("fsvalve", NULL);
+  tmp = g_strdup_printf ("recv_valve_%d_%d_%d", self->priv->session->id,
+      self->priv->ssrc, self->priv->pt);
+  self->priv->valve = gst_element_factory_make ("fsvalve", tmp);
+  g_free (tmp);
 
   if (!self->priv->valve) {
     self->priv->construction_error = g_error_new (FS_ERROR,
@@ -527,7 +531,10 @@ fs_rtp_sub_stream_constructed (GObject *object)
     return;
   }
 
-  self->priv->capsfilter = gst_element_factory_make ("capsfilter", NULL);
+  tmp = g_strdup_printf ("recv_capsfilter_%d_%d_%d", self->priv->session->id,
+      self->priv->ssrc, self->priv->pt);
+  self->priv->capsfilter = gst_element_factory_make ("capsfilter", tmp);
+  g_free (tmp);
 
   if (!self->priv->capsfilter) {
     self->priv->construction_error = g_error_new (FS_ERROR,
-- 
1.5.6.5




More information about the farsight-commits mailing list